[TEST] add PHPStan to build #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhujer
commented
Aug 23, 2017
| @@ -171,7 +171,7 @@ public function testAsyncIntegration($testProcedure, $skip, $setupProcedure, $fi | |||
| } | |||
|
|
|||
| if (null !== $setupProcedure) { | |||
| $this->processProcedure(current($setupProcedure), 'setup'); | |||
| $this->processProcedure(current($setupProcedure), 'setup', $fileName); | |||
There was a problem hiding this comment.
This one is related to recent change 51b9b9b - and it would be discovered immediately
mhujer
commented
Aug 23, 2017
| @@ -328,6 +328,9 @@ public function operationDo($operation, $lastOperationResult, &$context, $testNa | |||
| $endpointParams->client['headers'] = $headers; | |||
| } | |||
|
|
|||
| if (!is_string($method)) { | |||
There was a problem hiding this comment.
It may not be a string at this point and $this->mapEndpoint would fail, hence the added check.
mhujer
force-pushed
the
mh-phpstan-tests
branch
from
9538780 to
81be039
Compare
|
I like it! I'm all for static type checking and analytical lints. After working heavily in Rust and Java, coming back to PHP is painful without a compiler watching my back :) |
|
I plan to do the similar clean up to the Cool thing about PHPStan is that is has something called "levels". You start by checking and fixing on the first one (which reports the most obvious errors) and gradually level-up :-) |
mhujer
force-pushed
the
mh-phpstan-tests
branch
from
81be039 to
aedd396
Compare
|
Static checking activate! |
|
😄 |
polyfractal
pushed a commit
that referenced
this pull request
Nov 14, 2017
* PHPUnit 5.7.21 + update config + fix risky tests * PHPUnit 6.3.0 * use $this->expectException instead of annotation * [TEST] fixes of issues detected by phpstan * phpstan setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest adding PHPStan as a part of the build (for the tests now, for the src later). It is a tool that statically analyzes PHP code and detects potential issues - such as missing required parameters for methods, incorrect parameter types and many others.
We've been using it at the company I'm working at since December and it helped us to catch various issues early in development phase.
--
This PR depends on #627 (which must be merged first to prevent conflicts)