Snapshot and Restore #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry for the delay on this, was traveling all last week. I've skimmed your PR and I think it looks good. I'll pull it locally a little later today and verify it passes tests, but I don't think it will be a problem. Thanks for the PR! Would you mind signing the Elasticsearch CLA? It'll only take a second, and then all future PRs can be merged immediately :) http://www.elasticsearch.org/contributor-agreement/ |
|
I went ahead and implemented this myself in a related patch, since this is a fairly important bug and I haven't heard back from you. Thanks for the PR anyhow, please sign the CLA next time so I can merge your changes! :) |
polyfractal
added a commit
that referenced
this pull request
May 8, 2014
Also fixes typo in SnapshotNamespace->restore() method, as well as general formatting corrections Closes #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
What do you think about that ?
Thanks.
Pierre