-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer: PSR-4 + autoload-dev #198
Conversation
Sorry for the delay on this...slipped through my inbox without noticing. Are there any gotchas to PSR-4 that I should be aware of? I haven't really followed it, and don't know much about it. It looks nice from a superficial skimming... From what I can gather, it's mostly dropping backwards compatibility features that were inherited from PEAR? Also, would you mind signing the Elasticsearch CLA so I can merge this? |
PSR-4 is compatible with PSR-0 if you don't use underscores as namespace separator (this was the standard was before PHP has namespaces). You also could remove the directories that only exist for pointing into the first namespace but this would require changing directory layout and would be a BC break. Without changing the directory structure or adding non namespaces classes including an underscore there is no BC break. The This PR doesn't contain license specific logic. It's only a composer configuration. I'm ok with it if you or someone else creates a new PR/commit without referencing me. |
Awesome, thanks for the explanation. And good to know about the deprecation, I didn't realize that had happened. Will definitely update to PSR-4! (especially since it doesn't seem like it will require any real changes to the project) We're required to get CLA signatures, even for small things like typos in documentation or configuration changes. Since you're ok with it, I'll just apply the change myself (but I'll leave a note of attribution in the commit message). Thanks again! |
Related to #198, thanks to marc-mabe for identifying this problem!
Related to #198, thanks to marc-mabe for identifying this problem!
Related to #198, thanks to marc-mabe for identifying this problem!
Merged in the change myself, thanks again! |
Related to elastic#198, thanks to marc-mabe for identifying this problem!
No description provided.