Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Jun 10, 2021

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@russcam
Copy link
Contributor Author

russcam commented Jun 14, 2021

@stevejgordon should this also be backported to 7.x?

@stevejgordon
Copy link
Contributor

@russcam Yes I think so, thanks

@stevejgordon stevejgordon merged commit d5bb92e into master Jun 29, 2021
@stevejgordon stevejgordon deleted the editorconfig/naming-rules branch June 29, 2021 06:42
@github-actions
Copy link
Contributor

The backport to 7.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.x 7.x
# Navigate to the new working tree
cd .worktrees/backport-7.x
# Create a new branch
git switch --create backport-5723-to-7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 d5bb92eaf682fd98648e2a60affcad3ec8e9b570
# Push it to GitHub
git push --set-upstream origin backport-5723-to-7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.x

Then, create a pull request where the base branch is 7.x and the compare/head branch is backport-5723-to-7.x.

stevejgordon pushed a commit that referenced this pull request Jul 1, 2021
stevejgordon added a commit that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants