adding support for enable_position_increments property on ITokenCountProperty #5188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Property and ITokenCountPropertyDescriptor
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
russcam
suggested changes
Dec 17, 2020
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
Just one small change, otherwise LGTM
src/Nest/Mapping/Types/Specialized/TokenCount/TokenCountAttribute.cs
Outdated
Show resolved
Hide resolved
…ute.cs Co-authored-by: Russ Cam <[email protected]>
russcam
approved these changes
Dec 17, 2020
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
changes LGTM. Will leave it to @stevejgordon and @Mpdreamz to merge 👍
Contributor
Author
|
Have opened a PR against the 7.x branch as well. Since I'm using the latest 7.10.1 NEST nuget package. I'm assuming that's the correct branch for the PR merge? #5189 |
Contributor
No need to open another PR for 7.x, we'll handle the backport to the relevant branches 🙂 |
Contributor
stevejgordon
pushed a commit
that referenced
this pull request
Dec 17, 2020
…perty (#5188) * adding support for enable_position_increments property on ITokenCountProperty and ITokenCountPropertyDescriptor * Update src/Nest/Mapping/Types/Specialized/TokenCount/TokenCountAttribute.cs Co-authored-by: Russ Cam <[email protected]> (cherry picked from commit 70f9b5d)
stevejgordon
pushed a commit
that referenced
this pull request
Dec 17, 2020
…perty (#5188) * adding support for enable_position_increments property on ITokenCountProperty and ITokenCountPropertyDescriptor * Update src/Nest/Mapping/Types/Specialized/TokenCount/TokenCountAttribute.cs Co-authored-by: Russ Cam <[email protected]> (cherry picked from commit 70f9b5d)
stevejgordon
added a commit
that referenced
this pull request
Dec 22, 2020
…perty (#5188) (#5197) * adding support for enable_position_increments property on ITokenCountProperty and ITokenCountPropertyDescriptor * Update src/Nest/Mapping/Types/Specialized/TokenCount/TokenCountAttribute.cs Co-authored-by: Russ Cam <[email protected]> (cherry picked from commit 70f9b5d) Co-authored-by: Reji Dasan <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 22, 2020
…perty (#5188) (#5196) * adding support for enable_position_increments property on ITokenCountProperty and ITokenCountPropertyDescriptor * Update src/Nest/Mapping/Types/Specialized/TokenCount/TokenCountAttribute.cs Co-authored-by: Russ Cam <[email protected]> (cherry picked from commit 70f9b5d) Co-authored-by: Reji Dasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the provisioning of enable_position_increments on
ITokenCountPropertyandITokenCountPropertyDescriptorThe problem this PR is solving is described in detail in this Issue: #5186