Skip to content

Remove "_source_include" and "_source_exclude" from overrides. #4070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Remove "_source_include" and "_source_exclude" from overrides. #4070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/SearchOverrides.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ public class SearchOverrides : EndpointOverridesBase
"q", //we dont support GET searches
"sort",
"_source",
"_source_include",
"_source_exclude",
"_source_includes",
"_source_excludes",
"track_scores",
Expand Down
1 change: 0 additions & 1 deletion src/CodeGeneration/ApiGenerator/Configuration/Overrides/Endpoints/UpdateOverrides.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public class UpdateOverrides : EndpointOverridesBase
public override IEnumerable<string> SkipQueryStringParams => new[]
{
"fields",
"_source_include", "_source_exclude",
"_source_includes", "_source_excludes"
};
}
Expand Down
3 changes: 1 addition & 2 deletions src/CodeGeneration/ApiGenerator/Configuration/Overrides/GlobalOverrides.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ public class GlobalOverrides : EndpointOverridesBase
"parent", //can be removed once https://github.com/elastic/elasticsearch/pull/41098 is in
"copy_settings", //this still needs a PR?
"source", // allows the body to be specified as a request param, we do not want to advertise this with a strongly typed method
"timestamp",
"_source_include", "_source_exclude", // can be removed once https://github.com/elastic/elasticsearch/pull/41439 is in
"timestamp"
};
}
}
2 changes: 1 addition & 1 deletion src/CodeGeneration/ApiGenerator/Domain/Specification/QueryParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public class QueryParameters
{
private static readonly string[] FieldsParams =
{
"fields", "_source_include", "_source_exclude", "_source_includes", "_source_excludes",
"fields", "_source_includes", "_source_excludes",
};

public bool Skip { get; set; }
Expand Down