Actually use the setting to customize the serializer settings #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It sure was, I had fixed this in my local branch already but hadn't gotten around to pushing it yet. I will hopefully get some time today/tomorrow to do a new release. Thanks @bytenik ! |
Mpdreamz
added a commit
that referenced
this pull request
Nov 13, 2013
Actually use the setting to customize the serializer settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a setting exposed to customize the JSON serializer, by providing a delegate that takes the serializer settings and modifies it. However, the setting isn't used anywhere.
My project requires me to hook up some various changes to the serializer. Without this working properly, I'm forced to tap the private fields in NEST using reflection in order to customize the serializer, which is horribly hackish. Since this setting is exposed in NEST, I'm assuming it was intended to do something. :)