Fix/7.0 ga code generation #3664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecs without regenerating all the code
…ot and delete when no longer needed
russcam
approved these changes
Apr 12, 2019
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
LGTM. Left a small comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*.patch.jsonwhile fix #35262 define deprecations of API's as a whole and urls elasticsearch#39063 is pending*.patch.jsonfiles in a_Patchedfolder so that we can keep track of these easier.6.7for the xpack downloads.part.requiredbased on exposed urls. A warning is logged on the console if this happens so that we can fix the issue upstream.Did a new code gen using 7.0 GA spec files, did not yield anything major, several new properties.