expose SetTcpKeepAlive() on ConnectionSettings #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subclass HttpConnection to set it
Contributor
|
LGTM 👍 |
gmarz
added a commit
that referenced
this pull request
Feb 25, 2015
…keep-alive expose SetTcpKeepAlive() on ConnectionSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so you do not need to subclass HttpConnection and override
AlterServicePoint()to set it.Sidenote:
I also added an Obsolete on
HttpClientConnectionindicating its not as well tested asHttpConnectionand as a heads up that with Elasticsearch.NET/NEST 2.0 we'll be moving the defaultHttpConnectionover toHttpClientanyway.Im still not totally sure about moving over to
HttpClientthough, yes its a nicer interface, but there is a real benefit of having a true synchronous code path without the overhead of async dispatching even if that happens on IOCP threads. Calling.Resulton a task is not really equivalent.We might endup ifdeffing
HttpConnectionspecifically foraspnetcore50, still lots to research and measure :)