Feature/improve codegeneration #1082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, endpoints that were removed from newer versions of the REST spec were subsequently removed from the low-level clients generated classes as well. We need to keep these endpoints in order to maintain backwards compatibility with older versions of elasticsearch.
All endpoints are now kept in the
ApiEndpointsfolder. This folder always contains the state in which the low-level client was generated from. Since files are never deleted from this folder, when an endpoint is removed from the REST spec, it's file will still remain.When
useCache==true, we skip downloading of the REST spec and generate directly from the existing contents ofApiEndpointsdirectory.This change requires that the
ApiEndpointsfolder and it's contents are always checked in.WIP: Need to fix build errors in NEST after updating to the 1.4 spec before this can be merged.