Json.NET throws exception while deserializing relative Uri

[megri]

This bug was introduced with commit df2bfc9.

The problem is that the Uri is created without a UriKind, thus implicitly using UriKind.Absolute, which throws an exception for relative Uris.

Is there a compelling reason to replace the standard [non-buggy] serializer?

[Mpdreamz]

The reason was that over the years i've had many people surprised by the fact that Uri properties serialise as objects by default when 9/10 times they want to serialise it as string and deserialise it Uri.

So build in support to do that instead of having folks write their own json converter made sense.

I could make it the Uri serialization optin/optout through ConnectionSettings. My gut says it should be an opt-out, any thoughts on this?

Ping @crunchie84 for his thoughts as well since he wrote the PR for it initially.

[crunchie84]

My initial PR was only for making the Uri <=> String json conversion easier. If this is a headache for the majority of uses of Nest i would recommend setting it default to serialize Uri's to string.

Since 1.0.0 release of Nest introduces a lot of other breaking changes for the better this seems the moment to do so. People can still override the (new) default serialization behaviour by implementing AddContractJsonConverters() @Mpdreamz ?

[megri]

@Mpdreamz Uris are serialized to strings since at least Newtonsoft.Json 5.0.8, the oldest version I currently have available.

class Foo {
    public Uri X { get; set; }
}

JsonConvert.SerializeObject(new Foo { X = new Uri("http://www.google.com") });

serializes to {"X":"http://www.google.com/"} by the vanilla implementation

[Mpdreamz]

Ok will investigate further, at the time of this commit we were on 6.0.1 so i wonder what is causing the difference in observed behavior.

https://github.com/elasticsearch/elasticsearch-net/blob/df2bfc99db9862db53f4ca6012ad7b37d57ade7e/src/Nest/packages.config#L3

[gmarz]

I've confirmed that Json.NET does indeed serialize Uri -> string out of the box and have proposed the above PR to remove UriJsonConverter.

I don't doubt that there was probably once a good reason for it, but as it stands now I can't reproduce a case where a Uri is serialized to an object.