-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The new product version check rejects oss distributions? #1519
Comments
This issue is a breaking change for us. IMO a minor version update (7.13 -> 7.14) should not introduce a change like this, it should only be included in a major version update. |
With the Please review the client's compatibility that states the forward compatibility. The recommendation is to upgrade the server first, then the client. If you are blocked to upgrade the cluster, we're happy to help you unblock the situation or please pin the client to an |
IMHO this breaking change shouldn't happen in a minor release although I'm well aware of all the political situation involved here. Some people simply do not have the choice of not using AWS' flavor and you're intentionally hurting them with this. A much more user-friendly approach would be for this check to be a warning stating that compatibility is not guaranteed with non-Elastic flavors instead of a fatal error that for sure caused lots of critical incidents around the world for ES users, at least until 8.0.0. |
We're also having this issue. It is a breaking change. |
@jo3n Apparently there are no plans to fix this in 7.14, so the solution is to pin your dependency on 7.13. |
It look likes we should move to new clients of OpenSearch that should be available soon. |
I can also confirm that downgrading to |
But Elastic Cloud is trash, low quality service, we had outage for 3 days with no support, and in a few months another outage for 1 day with no support - it's impossible to reach their teams when there are outages... I even called their office back then and they do not pick up the phone |
Just an update in case anyone starts looking for options, OpenSearch client is now released: https://www.npmjs.com/package/@opensearch-project/opensearch |
we must use version <=7.13 due to this issue: elastic/elasticsearch-js#1519
we must use version <=7.13 due to this issue: elastic/elasticsearch-js#1519
we must use version <=7.13 due to this issue: elastic/elasticsearch-js#1519
we must use version <=7.13 due to this issue: elastic/elasticsearch-js#1519
we must use version <=7.13 due to this issue: elastic/elasticsearch-js#1519
we must use version <=7.13 due to this issue: elastic/elasticsearch-js#1519
we must use version <=7.13 due to this issue: elastic/elasticsearch-js#1519
Since you're supposedly re-embracing open source, you should just ditch this restriction. |
💬 Questions and Help
@delvedor Is there a reason why the new product version check introduced in 7.14.0 doesn't accept distributions with
oss
as flavor?https://github.com/elastic/elasticsearch-js/blob/master/lib/Transport.js#L591-L595
The text was updated successfully, but these errors were encountered: