Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new product version check rejects oss distributions? #1519

Closed
RTodorov opened this issue Aug 13, 2021 · 10 comments
Closed

The new product version check rejects oss distributions? #1519

RTodorov opened this issue Aug 13, 2021 · 10 comments

Comments

@RTodorov
Copy link

RTodorov commented Aug 13, 2021

💬 Questions and Help

@delvedor Is there a reason why the new product version check introduced in 7.14.0 doesn't accept distributions with oss as flavor?

https://github.com/elastic/elasticsearch-js/blob/master/lib/Transport.js#L591-L595

          if (result.body.version.build_flavor !== 'default') {
            debug('Bad build_flavor')
            this[kProductCheck] = 4
            return productCheckEmitter.emit('product-check', null, false)
          }
@dlocke-rheaply
Copy link

This issue is a breaking change for us. IMO a minor version update (7.13 -> 7.14) should not introduce a change like this, it should only be included in a major version update.

@philkra
Copy link

philkra commented Aug 16, 2021

With the 7.11 release of Elasticsearch, we will no longer be releasing oss-only distributions, as stated in the FAQ on license change. The recommendation is to upgrade to the latest default distribution of Elasticsearch, which is free to use under Elastic License v2.

Please review the client's compatibility that states the forward compatibility. The recommendation is to upgrade the server first, then the client. If you are blocked to upgrade the cluster, we're happy to help you unblock the situation or please pin the client to an <7.14 version according to your cluster.

@philkra philkra closed this as completed Aug 16, 2021
@RTodorov
Copy link
Author

IMHO this breaking change shouldn't happen in a minor release although I'm well aware of all the political situation involved here. Some people simply do not have the choice of not using AWS' flavor and you're intentionally hurting them with this.

A much more user-friendly approach would be for this check to be a warning stating that compatibility is not guaranteed with non-Elastic flavors instead of a fatal error that for sure caused lots of critical incidents around the world for ES users, at least until 8.0.0.

@jo3n
Copy link

jo3n commented Aug 17, 2021

We're also having this issue. It is a breaking change.

@dlocke-rheaply
Copy link

@jo3n Apparently there are no plans to fix this in 7.14, so the solution is to pin your dependency on 7.13.

@xfournet
Copy link

It look likes we should move to new clients of OpenSearch that should be available soon.
See https://aws.amazon.com/blogs/opensource/keeping-clients-of-opensearch-and-elasticsearch-compatible-with-open-source/

@futin
Copy link

futin commented Aug 24, 2021

I can also confirm that downgrading to 7.13 fixed this issue. But really disappointing that minor update broke our whole production. Everyone should definitely look for an alternative since this was a very unpleasant experience.

@Dmitry1987
Copy link

But Elastic Cloud is trash, low quality service, we had outage for 3 days with no support, and in a few months another outage for 1 day with no support - it's impossible to reach their teams when there are outages... I even called their office back then and they do not pick up the phone

@falnyr
Copy link

falnyr commented Oct 8, 2021

Just an update in case anyone starts looking for options, OpenSearch client is now released: https://www.npmjs.com/package/@opensearch-project/opensearch

mosufy added a commit to reflex-media/lesgo-framework that referenced this issue Feb 14, 2022
msherman64 added a commit to ChameleonCloud/kolla that referenced this issue Jul 27, 2023
msherman64 added a commit to ChameleonCloud/kolla that referenced this issue Aug 3, 2023
msherman64 added a commit to ChameleonCloud/kolla that referenced this issue Aug 3, 2023
msherman64 added a commit to ChameleonCloud/kolla that referenced this issue Aug 3, 2023
msherman64 added a commit to ChameleonCloud/kolla that referenced this issue Aug 4, 2023
@MomentQYC
Copy link

Since you're supposedly re-embracing open source, you should just ditch this restriction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants