Skip to content

Docs: Clean up for asciidoctor #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2019
Merged

Docs: Clean up for asciidoctor #1275

merged 1 commit into from
Apr 8, 2019

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 8, 2019

This makes three changes in preparation for switching the docs to
Asciidoctor:

  1. Fixes a broken link. As a side effect this fixes a missing emphasis
    in Asciidoctor that was caused by parsing issues with the _ in the old
    link.
  2. Fixes an added macro that renders "funny" in Asciidoctor.
  3. Replace a tab in a code example with spaces. AsciiDoc was doing this
    automatically but Asciidoctor preserves the tab. We don't need the tab.

@nik9000
Docs: Clean up for asciidoctor
44d7d96 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
@nik9000 nik9000 added the >docs label Apr 8, 2019
@nik9000 nik9000 requested a review from jbaiera April 8, 2019 14:07
@nik9000 nik9000 mentioned this pull request Apr 8, 2019
Merged
jbaiera
jbaiera approved these changes Apr 8, 2019
View reviewed changes
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nik9000 nik9000 merged commit 486ebf8 into master Apr 8, 2019
@nik9000 nik9000 deleted the docs_asciidoc_cleanup branch April 8, 2019 14:18
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
4a9286b 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
cfb1311 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
5267d6d 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
9258c63 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
b43ef59 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
3e68b00 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
b50df90 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
b902a84 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
30dd98d 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
a0ec2d0 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
0de99b5 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
32ee7d5 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
a8f5cf9 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
931f3b7 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
3c3a4eb 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
bd67a05 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
f0c516e 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
f3d4966 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
64a4333 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
21106d2 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
nik9000 added a commit that referenced this pull request Apr 8, 2019
@nik9000
Docs: Clean up for asciidoctor (#1275)
8fab40d 
This makes three changes in preparation for switching the docs to
Asciidoctor:
1. Fixes a broken link. As a side effect this fixes a missing emphasis
in Asciidoctor that was caused by parsing issues with the `_` in the old
link.
2. Fixes an `added` macro that renders "funny" in Asciidoctor.
3. Replace a tab in a code example with spaces. AsciiDoc was doing this
automatically but Asciidoctor preserves the tab. We don't need the tab.
@nik9000
Copy link
Member Author

nik9000 commented Apr 8, 2019

Merged and backported!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaiera jbaiera jbaiera approved these changes

Assignees

No one assigned

Labels

>docs v2.0.4 v2.1.3 v2.2.1 v2.3.5 v2.4.1 v5.0.2 v5.1.1 v5.2.0 v5.3.3 v5.4.1 v5.5.0 v5.6.13 v6.0.1 v6.1.2 v6.2.3 v6.3.2 v6.4.3 v6.5.0 v6.6.0 v7.0.0 v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nik9000 @jbaiera