-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manticore transport unable to send custom headers with perform_request #66
Comments
/cc @picandocodigo |
Hi @kaisecheng, I'll look into this and make a patch release soon. Thanks! |
@picandocodigo Could you tell me approximately the delivery schedule of the patch? |
@kaisecheng I'll try to get it out as soon as possible this week time permitting or early next week if not. |
@kaisecheng I think I've managed to fix it. If you can test out the branch, that'd be great. If not I can merge and prepare a patch release soon. |
@picandocodigo Thanks for the patch. It works as expected |
@kaisecheng thanks for testing it! I'll publish a release soon 👍 |
@picandocodigo I'll be on PTO for three weeks. I am hoping to get a new release version of elasticsearch-transport for logstash-plugin this week before I go. It would be great if you could publish a release soon ❤️ |
@kaisecheng 8.2.4 is out with this fix, thanks! |
@picandocodigo thanks! Is it possible to backport the fix to elasticsearch-ruby 7.17 branch? Logstash plugins are still depending on 7.17 🙇 |
@kaisecheng |
elasticsearch-transport gem is unable to send custom headers
client.search(q: '*', size: 2, headers: {"Elastic-Api-Version"=>"2023-10-31"})
in Manticore implementation probably since 7.2.The headers are ignored and overwritten by the initial constructor headers.
Faraday and curb do merge with input headers, hence exclude in this bug
Reproduce steps
Test it against serverless endpoint which should return 400 when the header is not
"Elastic-Api-Version"=>"2023-10-31"
The last line is expected to get 400 but got 200 because the headers didn't send. You can initialize the
Elasticsearch::Client
with the wrong header "2024-10-31", the server returns 400.The text was updated successfully, but these errors were encountered: