Accept endpoint_id and path_params from client #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates elastic/elasticsearch-py#2435
This pull request changes
perform_request
to optionally acceptendpoint_id
andpath_parts
from the Elasticsearch client. Coupled with elastic/elasticsearch-py#2457, this fixes the span name:and adds path parts attributes (Elastic APM replaces dots with underscores):
I also added support for AsyncTransport:
It was convenient because the elasticsearch-py changes also apply to the async API, but I can open a separate pull request to bring OTel support to AsyncTransport first if you prefer.
I have done all my testing manually but I do plan to add an integration test in the future.