Add noop to request errors during cleanup
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a potential race condition that's hard to reproduce (it only happened 29 times in the last 30 days in our production environment). Kibana crashes with
EPIPEduring write operations (task manager writing the result of a task, task manager claiming tasks, Kibana during the setup phase, and multiple POST requests).The lack of stack traces in Kibana (elastic/elasticsearch-js#2235) doesn't help to identify if it's related to one specific request or spread across multiple ones. But the gut feeling is a race condition where potentially, multiple errors are emitted at once and only one is caught, cleaning the listener, and the next one crashes the app.
Happy to close this PR if you think that this change is not safe/sensible.