Merged
Conversation
Built packages can have content that was not in their source files, such as imported ECS fields. Validate final packages to ensure that content included during build is also valid.
Collaborator
mtojek
reviewed
Mar 7, 2022
mtojek
approved these changes
Mar 14, 2022
Contributor
mtojek
left a comment
There was a problem hiding this comment.
LGTM!
nit: if you haven't done it, you can double-check if command usage messages and "README" are up-to-date in terms of building&linting.
Member
Author
General behaviour doesn't change, so I guess we are fine there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built packages can have content that was not in their source files, such
as imported ECS fields. Validate final packages to ensure that content
included during build is also valid.
For example while testing
ValidateFromZipI found that some packagescontained ECS fields of type
match_text_only, that was not supportedin the spec (fixed in elastic/package-spec#284).
@mtojek not sure if this is the best place to do this validation, but I think
we should have something like this safeguard to ensure that built packages
still comply with the spec.