Skip to content

Validate built packages too#720

Merged
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:validate-built-packages
Mar 14, 2022
Merged

Validate built packages too#720
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:validate-built-packages

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Mar 4, 2022

Built packages can have content that was not in their source files, such
as imported ECS fields. Validate final packages to ensure that content
included during build is also valid.

For example while testing ValidateFromZip I found that some packages
contained ECS fields of type match_text_only, that was not supported
in the spec (fixed in elastic/package-spec#284).

@mtojek not sure if this is the best place to do this validation, but I think
we should have something like this safeguard to ensure that built packages
still comply with the spec.

Built packages can have content that was not in their source files, such
as imported ECS fields. Validate final packages to ensure that content
included during build is also valid.
@jsoriano jsoriano requested a review from a team March 4, 2022 16:48
@jsoriano jsoriano self-assigned this Mar 4, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-14T12:28:15.047+0000

  • Duration: 16 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 536
Skipped 1
Total 537

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nit: if you haven't done it, you can double-check if command usage messages and "README" are up-to-date in terms of building&linting.

@jsoriano
Copy link
Member Author

nit: if you haven't done it, you can double-check if command usage messages and "README" are up-to-date in terms of building&linting.

General behaviour doesn't change, so I guess we are fine there.

@jsoriano jsoriano merged commit 29d0efc into elastic:main Mar 14, 2022
@jsoriano jsoriano deleted the validate-built-packages branch March 14, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants