Force GeoIP db in all stack versions#619
Merged
marc-gr merged 3 commits intoelastic:masterfrom Dec 14, 2021
Merged
Conversation
mtojek
approved these changes
Dec 13, 2021
Contributor
mtojek
left a comment
There was a problem hiding this comment.
Let's add some context in the issue description why do we need this.
Let's make sure that CI status is green for test packages.
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Contributor
Author
|
/test |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forces to use the same GeoIP database for all stack versions to avoid inconsistencies in test outputs.
Since we were using a specific GeoIP database for 8.x, tests expected files will have different output if the geoip processor is used depending on which stack is used. Currently PRs in integrations are testing against 8.0.0, but tests on the 7.16.0 stack also run in master and in elastic-package PRs, generating errors for pipeline tests eg:
To avoid this, we force the same GeoIP database for any version of the stack, to provide consistency in tests output.