Skip to content

Force GeoIP db in all stack versions#619

Merged
marc-gr merged 3 commits intoelastic:masterfrom
marc-gr:force-geo-db
Dec 14, 2021
Merged

Force GeoIP db in all stack versions#619
marc-gr merged 3 commits intoelastic:masterfrom
marc-gr:force-geo-db

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Dec 13, 2021

Forces to use the same GeoIP database for all stack versions to avoid inconsistencies in test outputs.

Since we were using a specific GeoIP database for 8.x, tests expected files will have different output if the geoip processor is used depending on which stack is used. Currently PRs in integrations are testing against 8.0.0, but tests on the 7.16.0 stack also run in master and in elastic-package PRs, generating errors for pipeline tests eg:

-                "as": {
-                    "number": 35908
-                },
-                "geo": {
-                    "continent_name": "Asia",
-                    "country_iso_code": "BT",
-                    "country_name": "Bhutan",
-                    "location": {
-                        "lat": 27.5,
-                        "lon": 90.5
-                    }
-                },
                 "ip": "67.43.156.13",
                 "port": 80

To avoid this, we force the same GeoIP database for any version of the stack, to provide consistency in tests output.

@marc-gr marc-gr requested a review from mtojek December 13, 2021 13:47
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some context in the issue description why do we need this.

Let's make sure that CI status is green for test packages.

@mtojek mtojek requested review from P1llus and jsoriano December 13, 2021 13:50
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 13, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-14T10:45:36.958+0000

  • Duration: 56 min 3 sec

  • Commit: d2a2acf

Test stats 🧪

Test Results
Failed 0
Passed 605
Skipped 0
Total 605

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@marc-gr
Copy link
Contributor Author

marc-gr commented Dec 13, 2021

/test

@marc-gr marc-gr mentioned this pull request Dec 13, 2021
@marc-gr marc-gr merged commit 2924260 into elastic:master Dec 14, 2021
@marc-gr marc-gr deleted the force-geo-db branch December 14, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants