-
Notifications
You must be signed in to change notification settings - Fork 139
Stop implicitly validating generic.otel for otelcol input packages #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
teresaromero
merged 17 commits into
elastic:main
from
teresaromero:fix/generic-otel-dynamic-signal-types
Apr 16, 2026
Merged
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3693afb
fix: use generic.otel stream key for dynamic_signal_types input packages
teresaromero d1882d6
test: add policy test fixtures for dynamic_signal_types and zipkin otel
teresaromero a6e6349
fix: update example event in README for sql_server_input_otel
teresaromero 0a9330a
add mysql input otel package to test fixtures with dataset override
teresaromero 6e8c589
add stack version for mysql_input_otel package
teresaromero 8013f74
fix: avoid double .otel suffix and revert policyTemplate.Name derivat…
teresaromero 6c0f63a
fix: stop implicitly validating generic.otel for otelcol input packages
teresaromero 4002c43
fix: update example event in README for sql_server_input_otel
teresaromero 39f2a51
Merge branch 'main' of github.com:elastic/elastic-package into fix/ge…
teresaromero b7943cd
Refactor expectedDatasets function to remove unnecessary nil paramete…
teresaromero d8eacc7
Merge branch 'main' of github.com:elastic/elastic-package into fix/ge…
teresaromero 2fee08a
Enhance otelcol input handling in documentation and code. Updated AGE…
teresaromero b6dab53
Update MySQL and SQL Server input configurations and sample events. C…
teresaromero 09a1ccf
Merge branch 'main' of github.com:elastic/elastic-package into fix/ge…
teresaromero 9d6efc9
Merge branch 'main' of github.com:elastic/elastic-package into fix/ge…
teresaromero 188f6eb
Merge branch 'main' of github.com:elastic/elastic-package into fix/ge…
teresaromero 05a69e5
Update zipking after fix merged
teresaromero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "name": "otel-dynamic-test", | ||
| "description": "", | ||
| "namespace": "test", | ||
| "policy_id": "test-policy-id", | ||
| "package": { | ||
| "name": "otel_dynamic_input", | ||
| "version": "0.1.0" | ||
| }, | ||
| "inputs": { | ||
| "sqlreceiver-otelcol": { | ||
| "enabled": true, | ||
| "streams": { | ||
| "generic.otel": { | ||
| "enabled": true, | ||
| "vars": { | ||
| "data_stream.dataset": "generic.otel" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "force": false | ||
| } |
42 changes: 42 additions & 0 deletions
42
internal/kibana/testdata/otel_input_dynamic_signals_legacy.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "name": "otel-dynamic-test", | ||
| "description": "", | ||
| "namespace": "test", | ||
| "policy_id": "test-policy-id", | ||
| "enabled": true, | ||
| "package": { | ||
| "name": "otel_dynamic_input", | ||
| "title": "OTel Dynamic Signals Input Package", | ||
| "version": "0.1.0" | ||
| }, | ||
| "inputs": [ | ||
| { | ||
| "policy_template": "sqlreceiver", | ||
| "type": "otelcol", | ||
| "enabled": true, | ||
| "vars": { | ||
| "data_stream.dataset": { | ||
| "value": "generic.otel", | ||
| "type": "text" | ||
| } | ||
| }, | ||
| "streams": [ | ||
| { | ||
| "enabled": true, | ||
| "data_stream": { | ||
| "type": "", | ||
| "dataset": "generic.otel" | ||
| }, | ||
| "vars": { | ||
| "data_stream.dataset": { | ||
| "value": "generic.otel", | ||
| "type": "text" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "output_id": "", | ||
| "force": false | ||
| } |
23 changes: 23 additions & 0 deletions
23
internal/kibana/testdata/packages/otel_dynamic_input/manifest.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| format_version: 3.5.0 | ||
| name: otel_dynamic_input | ||
| title: OTel Dynamic Signals Input Package | ||
| description: >- | ||
| Minimal OTel input package with dynamic_signal_types used to verify that | ||
| BuildInputPackagePolicy uses "generic.otel" as the stream key. | ||
| type: input | ||
| version: 0.1.0 | ||
| categories: | ||
| - observability | ||
| conditions: | ||
| kibana: | ||
| version: "^9.4.0" | ||
| policy_templates: | ||
| - name: sqlreceiver | ||
| title: SQL Receiver | ||
| description: Collect SQL metrics and logs using OTel. | ||
| input: otelcol | ||
| template_path: input.yml.hbs | ||
| dynamic_signal_types: true | ||
| owner: | ||
| github: elastic/elastic-package | ||
| type: elastic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
test/packages/parallel/sql_server_input_otel/_dev/test/policy/test-default-config.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| connectors: | ||
| forward: {} | ||
| exporters: | ||
| elasticsearch/componentid-0: | ||
| endpoints: | ||
| - https://elasticsearch:9200 | ||
| inputs: [] | ||
| output_permissions: | ||
| default: | ||
| _elastic_agent_checks: | ||
| cluster: | ||
| - monitor | ||
| _elastic_agent_monitoring: | ||
| indices: [] | ||
| uuid-for-permissions-on-related-indices: | ||
| indices: | ||
| - names: | ||
| - logs-*-* | ||
| privileges: | ||
| - auto_configure | ||
| - create_doc | ||
| - names: | ||
| - metrics-*-* | ||
| privileges: | ||
| - auto_configure | ||
| - create_doc | ||
| processors: | ||
| resourcedetection/componentid-0: | ||
| detectors: | ||
| - system | ||
| transform/componentid-1: | ||
| log_statements: | ||
| - context: log | ||
| statements: | ||
| - set(attributes["data_stream.type"], "logs") | ||
| - set(attributes["data_stream.namespace"], "ep") | ||
| metric_statements: | ||
| - context: datapoint | ||
| statements: | ||
| - set(attributes["data_stream.type"], "metrics") | ||
| - set(attributes["data_stream.namespace"], "ep") | ||
| receivers: | ||
| sqlserver/componentid-0: | ||
| collection_interval: 10s | ||
| events: | ||
| db.server.query_sample: | ||
| enabled: false | ||
| db.server.top_query: | ||
| enabled: false | ||
| initial_delay: 1s | ||
| secret_references: [] | ||
| service: | ||
| pipelines: | ||
| logs: | ||
| exporters: | ||
| - elasticsearch/componentid-0 | ||
| receivers: | ||
| - forward | ||
| logs/componentid-0: | ||
| exporters: | ||
| - forward | ||
| processors: | ||
| - resourcedetection/componentid-0 | ||
| - transform/componentid-1 | ||
| receivers: | ||
| - sqlserver/componentid-0 | ||
| metrics: | ||
| exporters: | ||
| - elasticsearch/componentid-0 | ||
| receivers: | ||
| - forward | ||
| metrics/componentid-1: | ||
| exporters: | ||
| - forward | ||
| processors: | ||
| - resourcedetection/componentid-0 | ||
| - transform/componentid-1 | ||
| receivers: | ||
| - sqlserver/componentid-0 |
1 change: 1 addition & 0 deletions
1
test/packages/parallel/sql_server_input_otel/_dev/test/policy/test-default-config.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| vars: ~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still possible to override the dataset? For example in the case of mysql_input_otel it has
dynamic_signal_types: true, but its data should not go to generic data streams.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've added the case to the test fixtures and used the variable override to prove dataset can be overriden, but i dont see this is happening... i dont see the overriden value as dataset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be fixed with elastic/kibana#262000, or you have also tried with this branch?