Use fallback GeoDB in Elasticsearch#335
Merged
mtojek merged 2 commits intoelastic:masterfrom Apr 23, 2021
Merged
Conversation
andrewkroh
reviewed
Apr 23, 2021
| - "script.context.ingest.cache_max_size=2000" | ||
| - "script.context.processor_conditional.cache_max_size=2000" | ||
| - "script.context.template.cache_max_size=2000" | ||
| - "ingest.geoip.downloader.enabled=false" |
Member
There was a problem hiding this comment.
Do we test with 7.12.0 anywhere? I assume this property doesn't exist in that version and this would cause a failure.
Contributor
Author
There was a problem hiding this comment.
The 7.12.0 is unsupported since we introduced changes for the Fleet Server. Unfortunately it was an acknowledged risk.
Collaborator
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
P1llus
approved these changes
Apr 23, 2021
Member
P1llus
left a comment
P1llus
left a comment
There was a problem hiding this comment.
LGTM, I saw andrew's comment was already accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the GeoDB downloader in Elasticsearch.
It's a similar PR to the one introduced in Beats: elastic/beats#25248