Relax validation of subobject leaves for flattened fields #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test integrations |
23 tasks
|
Testing the change with LogsDB in https://buildkite.com/elastic/integrations/builds/15648. The network traffic package tests should pass. |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#11043 |
mrodm
reviewed
Sep 9, 2024
💚 Build Succeeded
History
cc @jsoriano |
mrodm
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added some additional validations for subobjects and arrays of objects in #1498, #1489 and related PRs. These validations only apply to packages with package spec starting on 3.0.1.
These tests rely on the structure of documents. With the adoption of features like
subobjects: falseor synthetic source the structure is lost, and exceptions based on spec version are not working, so the tests fail for cases where they should not for versions of the spec older than 3.0.1. This happens for example in thednsdata stream of thenetwork_trafficpackage when LogsDB is enabled.