Skip to content

Support decoding JSONs in embedded panels in dashboards#1825

Merged
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:embedded-json-objects
May 9, 2024
Merged

Support decoding JSONs in embedded panels in dashboards#1825
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:embedded-json-objects

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented May 8, 2024

Add support for decoding JSONs in embedded panels in dashboards, also add support for deconding control group inputs.

@jsoriano jsoriano requested a review from a team May 8, 2024 16:51
@jsoriano jsoriano self-assigned this May 8, 2024
@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented May 8, 2024

test integrations

@elasticmachine elasticmachine mentioned this pull request May 8, 2024
Closed
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented May 8, 2024

Created or updated PR in integrations repository to test this version. Check elastic/integrations#9819

mrodm
mrodm reviewed May 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into the created PR in integrations, there are some errors raised. For instance in beaconing:

Error: checking package failed: building package failed: encoding dashboards failed: encoding /opt/buildkite-agent/builds/bk-agent-prod-gcp-1715187930001048022/elastic/integrations/build/packages/beaconing/1.2.0/kibana/dashboard/beaconing-5c610e50-2d67-11ee-b990-0d17f5be0d77.json: expected list of panels, found string
[beaconing] run_tests_package failed

Comment thread internal/builder/dashboards.go Outdated
@jsoriano jsoriano mentioned this pull request May 8, 2024
Merged
@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented May 8, 2024

Looking into the created PR in integrations, there are some errors raised. For instance in beaconing:

Looks like some dashboards are already encoded in the repo, this should fix them: ba38007

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented May 8, 2024

test integrations

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented May 8, 2024

Created or updated PR in integrations repository to test this version. Check elastic/integrations#9819

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented May 8, 2024

💚 Build Succeeded

History

cc @jsoriano

mrodm
mrodm approved these changes May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsoriano jsoriano merged commit 901661e into elastic:main May 9, 2024
@jsoriano jsoriano deleted the embedded-json-objects branch May 9, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrodm mrodm mrodm approved these changes

Assignees

@jsoriano jsoriano

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsoriano @elasticmachine @mrodm