Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase format version to 2.5.1 for new packages #1152

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Feb 21, 2023

New packages that were generated, used 2.0.0 by default instead of the most recent format_version of 2.5.1. To make sure new packages have by default access to the most recent features, the format_version should be the latest one.

New packages that were generated, used 2.0.0 by default instead of the most recent format_version of 2.3.0. To make sure new packages have by default access to the most recent features, the format_version should be the latest one.
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-21T18:51:13.685+0000

  • Duration: 2 min 13 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ruflin ruflin self-assigned this Feb 21, 2023
@ruflin
Copy link
Contributor Author

ruflin commented Feb 21, 2023

Based on https://github.com/elastic/package-spec/tree/v2.5.1 it looks like the package-spec version is already at v2.5.1? Should I update it to this version directly?

Is there a way we could this template up-to-date in an automatic way?

@jsoriano
Copy link
Member

Based on https://github.com/elastic/package-spec/tree/v2.5.1 it looks like the package-spec version is already at v2.5.1? Should I update it to this version directly?

Sounds good.

Is there a way we could this template up-to-date in an automatic way?

I see some options:

  • Use the spec.VersionsInChangelog() method to find the most recent version, and use this one. This would be more self-contained, but this may create invalid packages if we introduce breaking changes.
  • Similar one, try to obtain the same version as the package-spec in the go.mod.
  • Create a CI job that triggers on package-spec releases, and opens a PR in elastic-package updating the version. This is probably the best option to avoid breaking things unexpectedly.

@jsoriano
Copy link
Member

Follow up issue created to automate the update #1155.

@ruflin ruflin changed the title Increase format version to 2.3.0 for new packages Increase format version to 2.5.1 for new packages Feb 21, 2023
@ruflin
Copy link
Contributor Author

ruflin commented Feb 21, 2023

Thanks for the follow up issue. No strong preference on my end.

I update the PR to 2.5.1.

@ruflin ruflin merged commit 962d109 into elastic:main Feb 21, 2023
@ruflin ruflin deleted the increase-format-version branch February 21, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants