Skip to content

Fix XML doc comment and log level #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevejgordon merged 1 commit into from
Mar 21, 2025
Merged

Fix XML doc comment and log level #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Elastic.OpenTelemetry.Core/Configuration/CompositeElasticOpenTelemetryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,11 @@ internal bool GlobalLogEnabled

private static string GetDefaultLogDirectory()
{
var applicationMoniker = "elastic-otel-dotnet";
const string applicationMoniker = "elastic-otel-dotnet";

if (IsOSPlatform(OSPlatform.Windows))
return Path.Combine(GetFolderPath(SpecialFolder.ApplicationData), "elastic", applicationMoniker);

if (IsOSPlatform(OSPlatform.OSX))
return Path.Combine(GetFolderPath(SpecialFolder.LocalApplicationData), "elastic", applicationMoniker);

Expand All @@ -192,9 +194,9 @@ private static string GetDefaultLogDirectory()
/// <summary>
/// The default log directory if file logging was enabled but non was specified
/// <para>Defaults to: </para>
/// <para> - %PROGRAMDATA%\elastic\apm-agent-dotnet (on Windows)</para>
/// <para> - /var/log/elastic/apm-agent-dotnet (on Linux)</para>
/// <para> - ~/Library/Application_Support/elastic/apm-agent-dotnet (on OSX)</para>
/// <para> - %USERPROFILE%\AppData\Roaming\elastic\elastic-otel-dotnet (on Windows)</para>
/// <para> - /var/log/elastic/elastic-otel-dotnet (on Linux)</para>
/// <para> - ~/Library/Application Support/elastic/elastic-otel-dotnet (on OSX)</para>
/// </summary>
internal string LogDirectoryDefault { get; }

Expand Down
2 changes: 1 addition & 1 deletion src/Elastic.OpenTelemetry.Core/Diagnostics/LoggerMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public static void LogDistroPreamble(this ILogger logger, SdkActivationMethod ac
logger.LogInformation("EDOT log file: <disabled>");
}

logger.LogInformation("Activation method: {ActivationMethod}", activationMethod.ToString());
logger.LogDebug("Activation method: {ActivationMethod}", activationMethod.ToString());

#if NET8_0
logger.LogDebug("Matched TFM: {TargetFrameworkMoniker}", "net8.0");
Expand Down