Skip to content

Default to delta temporality for best compatibility #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevejgordon merged 1 commit into from
Mar 13, 2025
Merged

Default to delta temporality for best compatibility #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions examples/Example.MinimalApi/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@
"applicationUrl": "https://localhost:7140;http://localhost:5146",
"environmentVariables": {
"ASPNETCORE_ENVIRONMENT": "Development",
"OTEL_RESOURCE_ATTRIBUTES": "service.name=minimal-api-example",
"OTEL_EXPORTER_OTLP_ENDPOINT": "https://opentelemetry-playground-adbd73.apm.eu-west-1.aws.elastic.cloud:443",
"OTEL_EXPORTER_OTLP_HEADERS": "Authorization=ApiKey cVY3d3NKTUJXcWZFRWJwb2xURjA6bmNrZ0JiQ29SRWlEdUM1dzVORGYwZw=="
"OTEL_RESOURCE_ATTRIBUTES": "service.name=minimal-api-example"
}
},
"IIS Express": {
Expand Down
6 changes: 4 additions & 2 deletions src/Elastic.OpenTelemetry.AutoInstrumentation/AutoInstrumentationPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public TracerProviderBuilder BeforeConfigureTracerProvider(TracerProviderBuilder

/// <summary>
/// To configure metrics SDK before Auto Instrumentation configured SDK.
/// /// </summary>
/// </summary>
public MeterProviderBuilder BeforeConfigureMeterProvider(MeterProviderBuilder builder)
{
var logger = _components.Logger;
Expand All @@ -71,7 +71,9 @@ public MeterProviderBuilder BeforeConfigureMeterProvider(MeterProviderBuilder bu
{
builder.ConfigureResource(r => r.WithElasticDefaultsCore(_components, null, null));

builder.ConfigureServices(sc => sc.Configure<OtlpExporterOptions>(OtlpExporterDefaults.OtlpExporterOptions));
builder.ConfigureServices(sc => sc
.Configure<OtlpExporterOptions>(OtlpExporterDefaults.OtlpExporterOptions)
.Configure<MetricReaderOptions>(o => o.TemporalityPreference = MetricReaderTemporalityPreference.Delta));

logger.LogConfiguredSignalProvider(nameof(Signals.Metrics), nameof(MeterProviderBuilder), "<n/a>");

Expand Down
4 changes: 4 additions & 0 deletions src/Elastic.OpenTelemetry/Extensions/MeterProviderBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,13 @@ static void ConfigureBuilder(MeterProviderBuilder builder, BuilderState builderS

builder.ConfigureResource(r => r.WithElasticDefaults(builderState, services));

// When services is not null here, the options will have already been configured by the calling code.
if (services is null)
builder.ConfigureServices(sc => sc.Configure<OtlpExporterOptions>(OtlpExporterDefaults.OtlpExporterOptions));

builder.ConfigureServices(sc => sc.Configure<MetricReaderOptions>(o =>
o.TemporalityPreference = MetricReaderTemporalityPreference.Delta));

#if NET9_0_OR_GREATER
// On .NET 9, the contrib HTTP instrumentation is no longer required. If the dependency exists,
// it will be registered via the reflection-based assembly scanning.
Expand Down