Refine public extension methods#244
Merged
Merged
Conversation
stevejgordon
changed the title
stevejgordon
force-pushed
the
hostapplicationbuilder-method-overloads
branch
from
33ce429 to
8ca51d1
Compare
jackshirazi
approved these changes
Mar 10, 2025
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some redundant public extension methods for skipping OtlpExporter registration, preferring the extensions that accept an
ElasticOpenTelemetryOptionsinstance. Removing these avoids confusion and simplifies documentation.This also adds null checks and exception XML docs for the
ServiceCollectionExtensions.