feat: cancel brush event with escape key#819
Merged
nickofthyme merged 6 commits intoelastic:masterfrom Sep 16, 2020
Merged
Conversation
nickofthyme
added
enhancement
markov00
approved these changes
Sep 16, 2020
Collaborator
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Tested locally and looks good.
nit: if we can avoid that hasBrushListener instance variable it will be great, if not I'm fine with the current implementation
Collaborator
Author
|
@markov00 Updated based on our talk. |
Collaborator
|
🎉 This PR is included in version 21.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [21.3.0](elastic/elastic-charts@v21.2.0...v21.3.0) (2020-09-16) ### Bug Fixes * legend dark mode hover color ([opensearch-project#820](elastic/elastic-charts#820)) ([d30c21f](elastic/elastic-charts@d30c21f)) ### Features * cancel brush/click event with escape key ([opensearch-project#819](elastic/elastic-charts#819)) ([5a9f21f](elastic/elastic-charts@5a9f21f)) * show crosshair for external pointer events ([opensearch-project#817](elastic/elastic-charts#817)) ([1721514](elastic/elastic-charts@1721514))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable canceling brushing and click of xy charts with Escape
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)