fix: stack as percentage with 0 or null values by markov00 · Pull Request #618 · elastic/elastic-charts

markov00 · 2020-04-03T10:34:17Z

Summary

This commit fix a regression related to the rendering of stacked area/bar charts where Y values are 0 or null and the stack is configured as percentage.
A new snapshot test was also added to cover that case

fix #617

Checklist

Delete any items that are not applicable to this PR.

Proper documentation or storybook story was added for features that require explanation or tutorials
Unit tests were updated or added to match the most common scenarios

This commit fix a regression related to the rendering of stacked area/bar charts where Y values are 0 or null and the stack is configured as percentage fix elastic#617

codecov-io · 2020-04-03T10:41:01Z

Codecov Report

Merging #618 into master will decrease coverage by 0.15%.
The diff coverage is 31.57%.

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   70.79%   70.63%   -0.16%     
==========================================
  Files         220      220              
  Lines        6409     6439      +30     
  Branches     1224     1229       +5     
==========================================
+ Hits         4537     4548      +11     
- Misses       1853     1872      +19     
  Partials       19       19

Impacted Files	Coverage Δ
...types/partition_chart/layout/types/config_types.ts	`100.00% <ø> (ø)`
...es/partition_chart/layout/types/viewmodel_types.ts	`80.00% <ø> (ø)`
...rtition_chart/layout/viewmodel/link_text_layout.ts	`7.31% <0.00%> (-0.80%)`	⬇️
...ypes/partition_chart/layout/viewmodel/viewmodel.ts	`13.28% <0.00%> (-0.22%)`	⬇️
src/chart_types/xy_chart/specs/line_annotation.tsx	`79.48% <ø> (ø)`
src/utils/commons.ts	`100.00% <ø> (ø)`
...artition_chart/renderer/canvas/canvas_renderers.ts	`6.29% <3.22%> (-0.72%)`	⬇️
...hart_types/partition_chart/layout/config/config.ts	`67.74% <100.00%> (+1.07%)`	⬆️
...chart_types/xy_chart/utils/stacked_series_utils.ts	`97.80% <100.00%> (+0.27%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a691b...d985632. Read the comment docs.

nickofthyme

LGTM. Checked Chrome and FF locally.

Checked storybook story and confirmed fix. Also checked banded area and bar charts and fitting function stories. All look good 👍

Also checked y0Accessor, looks accurate but a little funcky.

rshen91

LGTM checked out locally on Chrome - thanks for writing really clear tests and adding the new story in storybook

This commit fix a regression related to the rendering of stacked area/bar charts where Y values are 0 or null and the stack is configured as percentage fix elastic#617

This commit fix a regression related to the rendering of stacked area/bar charts where Y values are 0 or null and the stack is configured as percentage fix #617

## [18.1.2](v18.1.1...v18.1.2) (2020-04-06) ### Bug Fixes * stack as percentage with 0 or null values ([#618](#618)) ([#619](#619)) ([65634a7](65634a7)), closes [#617](#617)

## [18.2.1](v18.2.0...v18.2.1) (2020-04-07) ### Bug Fixes * stack as percentage with 0 or null values ([#618](#618)) ([7be1f63](7be1f63)), closes [#617](#617)

markov00 · 2020-04-07T08:48:32Z

🎉 This PR is included in version 18.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This commit review the work done in elastic#618 to fix the following case: if we are stacking areas in percentage mode and the values for all series are 0 we shall use 0% as value for each point in that bucket. In the aforementioned PR we were handling that case as null, completely disconnecting the previous data points from the following ones on the chart.

This commit review the work done in #618 to fix the following case: if we are stacking areas in percentage mode and the values for all series are 0 we shall use 0% as value for each point in that bucket. In the aforementioned PR we were handling that case as null, completely disconnecting the previous data points from the following ones on the chart.

## [18.2.1](elastic/elastic-charts@v18.2.0...v18.2.1) (2020-04-07) ### Bug Fixes * stack as percentage with 0 or null values ([opensearch-project#618](elastic/elastic-charts#618)) ([9de7b60](elastic/elastic-charts@9de7b60)), closes [opensearch-project#617](elastic/elastic-charts#617)

fix: stack as percentage with 0 or null values

f0d3298

This commit fix a regression related to the rendering of stacked area/bar charts where Y values are 0 or null and the stack is configured as percentage fix elastic#617

markov00 added bug Something isn't working :data Data/series/scales related issue regression labels Apr 3, 2020

markov00 self-assigned this Apr 3, 2020

markov00 requested review from monfera, nickofthyme and rshen91 April 3, 2020 10:34

markov00 mentioned this pull request Apr 3, 2020

[TSVB] Wrongly display stacked as percentage charts elastic/kibana#62419

Closed

nickofthyme approved these changes Apr 3, 2020

View reviewed changes

Comment thread src/chart_types/xy_chart/rendering/rendering.areas.test.ts

refactor: revert playground

d985632

rshen91 approved these changes Apr 3, 2020

View reviewed changes

markov00 merged commit 7be1f63 into elastic:master Apr 3, 2020

markov00 deleted the 2020-04-03_fix_rendering_0_stacked branch April 3, 2020 17:06

markov00 mentioned this pull request Apr 3, 2020

fix: stack as percentage with 0 or null values (#618) [18.1.x] #619

Merged

markov00 pushed a commit that referenced this pull request Apr 6, 2020

chore(release): 18.1.2 [skip ci]

383fef6

## [18.1.2](v18.1.1...v18.1.2) (2020-04-06) ### Bug Fixes * stack as percentage with 0 or null values ([#618](#618)) ([#619](#619)) ([65634a7](65634a7)), closes [#617](#617)

markov00 pushed a commit that referenced this pull request Apr 7, 2020

chore(release): 18.2.1 [skip ci]

699783e

## [18.2.1](v18.2.0...v18.2.1) (2020-04-07) ### Bug Fixes * stack as percentage with 0 or null values ([#618](#618)) ([7be1f63](7be1f63)), closes [#617](#617)

markov00 added the released Issue released publicly label Apr 7, 2020

markov00 mentioned this pull request Apr 8, 2020

fix: stacked percentage with zero values #622

Merged

2 tasks

nickofthyme mentioned this pull request Mar 4, 2021

Percentage area charts can have gaps #1053

Closed

2 tasks

This comment was marked as spam.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: stack as percentage with 0 or null values#618

fix: stack as percentage with 0 or null values#618
markov00 merged 2 commits intoelastic:masterfrom
markov00:2020-04-03_fix_rendering_0_stacked

markov00 commented Apr 3, 2020

Uh oh!

codecov-io commented Apr 3, 2020 •

edited

Loading

Uh oh!

nickofthyme left a comment

Uh oh!

Uh oh!

rshen91 left a comment

Uh oh!

markov00 commented Apr 7, 2020

Uh oh!

This comment was marked as spam.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

markov00 commented Apr 3, 2020

Summary

Checklist

Uh oh!

codecov-io commented Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rshen91 left a comment

Choose a reason for hiding this comment

Uh oh!

markov00 commented Apr 7, 2020

Uh oh!

This comment was marked as spam.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-io commented Apr 3, 2020 •

edited

Loading