fix(axis labels): offset previous space correctly#45
Merged
emmacunningham merged 3 commits intoelastic:masterfrom Feb 7, 2019
Merged
fix(axis labels): offset previous space correctly#45emmacunningham merged 3 commits intoelastic:masterfrom
emmacunningham merged 3 commits intoelastic:masterfrom
Conversation
markov00
approved these changes
Feb 7, 2019
Collaborator
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Thanks for this fix. Code looks good.
This fixes the overlapping labels issue that was surfacing in time series labels where the first and second labels would overlap even when showOverlappingTicks/Labels was false. The issue is that the previousOccupiedSpace variable which was being used to determine if a tick/label should be included in the set of visible ticks/labels was not being updated correctly for the first tick, causing the next tick to render (even when it should have been hidden). This commit fixes that value update as well as simplifies the initialization of the variable to make the logic flow a bit easier to follow. fixes elastic#42
emmacunningham
force-pushed
the
fix/time-series-labels
branch
from
6621828 to
f910177
Compare
Collaborator
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [1.0.1](elastic/elastic-charts@v1.0.0...v1.0.1) (2019-02-07) ### Bug Fixes * **axis labels:** offset previous space correctly ([opensearch-project#45](elastic/elastic-charts#45)) ([c28e0d7](elastic/elastic-charts@c28e0d7)), closes [opensearch-project#42](elastic/elastic-charts#42)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the overlapping labels issue that was surfacing in time series labels where the first and
second labels would overlap even when showOverlappingTicks/Labels was false. The issue is that the
previousOccupiedSpace variable which was being used to determine if a tick/label should be included
in the set of visible ticks/labels was not being updated correctly for the first tick, causing the
next tick to render (even when it should have been hidden). This commit fixes that value update as
well as simplifies the initialization of the variable to make the logic flow a bit easier to follow.
fixes #42