Skip to content

Conversation

@nickofthyme
Copy link
Collaborator

Summary

This PR fixes the build issue related to /tsx?/ files in ./.stroybook and ./.playground by adding these respective local directories to tsconfig.json includes.

With these changes, the files in these directories will now be enforced.

Checklist

Add respective local directory to tsconfig (i.e. ./.stroybook and ./.playground)
@nickofthyme nickofthyme added chore :docs Anything related to documentation, API, storybook labels Sep 13, 2019
@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #377 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   98.25%   98.27%   +0.02%     
==========================================
  Files          38       38              
  Lines        2801     2784      -17     
  Branches      661      657       -4     
==========================================
- Hits         2752     2736      -16     
  Misses         44       44              
+ Partials        5        4       -1
Impacted Files Coverage Δ
src/specs/settings.tsx 94.44% <0%> (-0.13%) ⬇️
src/chart_types/xy_chart/store/chart_state.ts 97.6% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb482be...8d79c80. Read the comment docs.

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickofthyme nickofthyme merged commit f37f94e into elastic:master Sep 16, 2019
@nickofthyme nickofthyme deleted the build/ts-config-issue branch September 16, 2019 14:44
@markov00
Copy link
Member

🎉 This PR is included in version 12.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore :docs Anything related to documentation, API, storybook released Issue released publicly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants