Skip to content

Conversation

@markov00
Copy link
Member

Summary

This commit reduce the opacity of points in areas and lines series when hovering over a series in
the legend

fix #291

from:
Screenshot 2019-08-17 at 01 47 16

to:
Screenshot 2019-08-17 at 01 46 33

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility, including a check against IE11
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

This commit reduce the opacity of points in areas and lines series when hovering over a series in
the legend

fix elastic#291
@markov00 markov00 added bug Something isn't working :interactions Interactions related issue :styling Styling related issue labels Aug 16, 2019
@markov00 markov00 requested a review from nickofthyme August 16, 2019 23:48
@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files          37       37           
  Lines        2715     2715           
  Branches      636      636           
=======================================
  Hits         2662     2662           
  Misses         48       48           
  Partials        5        5
Impacted Files Coverage Δ
...onents/react_canvas/utils/rendering_props_utils.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f13dd...bf53ac5. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Locally, LGTM

@markov00 markov00 merged commit 196341b into elastic:master Aug 19, 2019
@markov00 markov00 deleted the fix-point-fades branch August 19, 2019 15:06
markov00 pushed a commit that referenced this pull request Aug 19, 2019
# [9.2.0](v9.1.1...v9.2.0) (2019-08-19)

### Bug Fixes

* reduce opacity for points when hovering over legend items ([#322](#322)) ([196341b](196341b)), closes [#291](#291)

### Features

* add chart size type overrides ([#317](#317)) ([b8dc9e1](b8dc9e1)), closes [#177](#177)
@markov00
Copy link
Member Author

🎉 This PR is included in version 9.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 19, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working :interactions Interactions related issue released Issue released publicly :styling Styling related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hovering over series in legend for LineSeries' doesn't reduce opacity of dot of other series

3 participants