Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .playground/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
.chart {
position: relative;
width: 100%;
height: 50%;
height: 100%;
}
</style>
</head>
Expand Down
6 changes: 3 additions & 3 deletions src/components/chart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ import { LegendButton } from './legend/legend_button';
import { ReactiveChart as ReactChart } from './react_canvas/reactive_chart';
import { Tooltips } from './tooltips';
import { CursorEvent } from '../specs/settings';
import { ChartSize, getChartSize } from '../utils/chart_size';

interface ChartProps {
/** The type of rendered
* @default 'canvas'
*/
renderer: 'svg' | 'canvas';
size?: [number, number];
size?: ChartSize;
className?: string;
}

Expand Down Expand Up @@ -60,8 +61,7 @@ export class Chart extends React.Component<ChartProps> {
if (size) {
containerStyle = {
position: 'relative',
width: size[0],
height: size[1],
...getChartSize(size),
};
} else {
containerStyle = {};
Expand Down
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export * from './specs';
export { Chart } from './components/chart';
export { ChartSize, ChartSizeArray, ChartSizeObject } from './utils/chart_size';
export { TooltipType, TooltipValue, TooltipValueFormatter } from './chart_types/xy_chart/utils/interactions';
export { SpecId, GroupId, AxisId, AnnotationId, getAxisId, getGroupId, getSpecId, getAnnotationId } from './utils/ids';
export { ScaleType } from './utils/scales/scales';
Expand Down
62 changes: 62 additions & 0 deletions src/utils/chart_size.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
import { getChartSize } from './chart_size';

describe('chart size utilities', () => {
test('array', () => {
expect(getChartSize([100, 100])).toEqual({
width: 100,
height: 100,
});
expect(getChartSize([undefined, 100])).toEqual({
width: '100%',
height: 100,
});
expect(getChartSize([100, undefined])).toEqual({
width: 100,
height: '100%',
});
expect(getChartSize([undefined, undefined])).toEqual({
width: '100%',
height: '100%',
});
expect(getChartSize([0, '100em'])).toEqual({
width: 0,
height: '100em',
});
});
test('value', () => {
expect(getChartSize(1)).toEqual({
width: 1,
height: 1,
});
expect(getChartSize('100em')).toEqual({
width: '100em',
height: '100em',
});
expect(getChartSize(0)).toEqual({
width: 0,
height: 0,
});
});
test('object', () => {
expect(getChartSize({ width: 100, height: 100 })).toEqual({
width: 100,
height: 100,
});
expect(getChartSize({ height: 100 })).toEqual({
width: '100%',
height: 100,
});
expect(getChartSize({ width: 100 })).toEqual({
width: 100,
height: '100%',
});
expect(getChartSize({})).toEqual({
width: '100%',
height: '100%',
});
expect(getChartSize({ width: 0, height: '100em' })).toEqual({
width: 0,
height: '100em',
});
});
});
26 changes: 26 additions & 0 deletions src/utils/chart_size.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
export type ChartSizeArray = [number | string | undefined, number | string | undefined];
export interface ChartSizeObject {
width?: number | string;
height?: number | string;
}

export type ChartSize = number | string | ChartSizeArray | ChartSizeObject;

export function getChartSize(size: ChartSize) {
if (Array.isArray(size)) {
return {
width: size[0] === undefined ? '100%' : size[0],
height: size[1] === undefined ? '100%' : size[1],
};
} else if (typeof size === 'object') {
return {
width: size.width === undefined ? '100%' : size.width,
height: size.height === undefined ? '100%' : size.height,
};
}
const sameSize = size === undefined ? '100%' : size;
return {
width: sameSize,
height: sameSize,
};
}
72 changes: 72 additions & 0 deletions stories/styling.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ import {
Settings,
BaseThemeTypes,
LineSeriesStyle,
TooltipType,
RecursivePartial,
Theme,
} from '../src/';
import * as TestDatasets from '../src/utils/data_samples/test_dataset';
import { palettes } from '../src/utils/themes/colors';
Expand Down Expand Up @@ -103,6 +106,75 @@ const data2 = dg.generateSimpleSeries(40);
const data3 = dg.generateSimpleSeries(40);

storiesOf('Stylings', module)
.add('chart size', () => {
const theme: RecursivePartial<Theme> = {
chartMargins: {
bottom: 0,
left: 0,
top: 0,
right: 0,
},
};
return (
<div>
<Chart className={'story-chart'} size={{ width: 100, height: 50 }}>
<Settings tooltip={TooltipType.None} theme={theme} />
<BarSeries
id={getSpecId('bars')}
xScaleType={ScaleType.Linear}
yScaleType={ScaleType.Linear}
xAccessor="x"
yAccessors={['y']}
data={data2}
/>
</Chart>
<Chart className={'story-chart'} size={{ height: 50 }}>
<Settings tooltip={TooltipType.None} theme={theme} />
<BarSeries
id={getSpecId('bars')}
xScaleType={ScaleType.Linear}
yScaleType={ScaleType.Linear}
xAccessor="x"
yAccessors={['y']}
data={data2}
/>
</Chart>
<Chart className={'story-chart'} size={['50%', 50]}>
<Settings tooltip={TooltipType.None} theme={theme} />
<BarSeries
id={getSpecId('bars')}
xScaleType={ScaleType.Linear}
yScaleType={ScaleType.Linear}
xAccessor="x"
yAccessors={['y']}
data={data2}
/>
</Chart>
<Chart className={'story-chart'} size={[undefined, 50]}>
<Settings tooltip={TooltipType.None} theme={theme} />
<BarSeries
id={getSpecId('bars')}
xScaleType={ScaleType.Linear}
yScaleType={ScaleType.Linear}
xAccessor="x"
yAccessors={['y']}
data={data2}
/>
</Chart>
<Chart className={'story-chart'} size={50}>
<Settings tooltip={TooltipType.None} theme={theme} />
<BarSeries
id={getSpecId('bars')}
xScaleType={ScaleType.Linear}
yScaleType={ScaleType.Linear}
xAccessor="x"
yAccessors={['y']}
data={data2}
/>
</Chart>
</div>
);
})
.add('margins and paddings', () => {
const theme: PartialTheme = {
chartMargins: {
Expand Down