-
Notifications
You must be signed in to change notification settings - Fork 134
feat(theme): set default labelOptions.widthLimit in themes and update metric.titleWeight default to 500 #2802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maryam-saeidi
merged 6 commits into
elastic:main
from
maryam-saeidi:2801-set-theme-default-value
Mar 6, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6bb9bf5
feat(legend): default label widthLimit in themes
maryam-saeidi e60d7bc
feat(metric): set default titleWeight to 500
maryam-saeidi 588ca76
test(vrt): update screenshots [skip ci]
elastic-datavis[bot] 0495b9b
Update screenshots
maryam-saeidi c237639
test(vrt): update screenshots [skip ci]
elastic-datavis[bot] 98f2c39
Apply suggestions from code review
maryam-saeidi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
-567 Bytes
(98%)
...s/all.test.ts-snapshots/baselines/metric-alpha/array-of-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-806 Bytes
(94%)
...screenshots/all.test.ts-snapshots/baselines/metric-alpha/basic-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-462 Bytes
(97%)
...hots/all.test.ts-snapshots/baselines/metric-alpha/extra-badges-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.44 KB
(97%)
e2e/screenshots/all.test.ts-snapshots/baselines/metric-alpha/grid-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-802 Bytes
(94%)
...l.test.ts-snapshots/baselines/metric-alpha/trend-multiple-data-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-477 Bytes
(98%)
...all.test.ts-snapshots/baselines/test-cases/metric-trend-length-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-90 Bytes
(97%)
...horizontal/bullet-as-metric/should-render-with-negative-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-90 Bytes
(97%)
...l/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-91 Bytes
(97%)
...l/bullet-as-metric/should-render-with-positive-negative-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-92 Bytes
(97%)
...as-metric/should-render-with-positive-negative-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-90 Bytes
(97%)
...horizontal/bullet-as-metric/should-render-with-positive-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-89 Bytes
(97%)
...l/bullet-as-metric/should-render-with-positive-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-87 Bytes
(98%)
...rds-circle/bullet-as-metric/should-render-with-negative-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-88 Bytes
(98%)
...e/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-89 Bytes
(98%)
...e/bullet-as-metric/should-render-with-positive-negative-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-90 Bytes
(98%)
...as-metric/should-render-with-positive-negative-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-95 Bytes
(98%)
...rds-circle/bullet-as-metric/should-render-with-positive-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-92 Bytes
(98%)
...e/bullet-as-metric/should-render-with-positive-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+63 Bytes
(100%)
...c-vertical/bullet-as-metric/should-render-with-negative-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+62 Bytes
(100%)
...l/bullet-as-metric/should-render-with-negative-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+65 Bytes
(100%)
...l/bullet-as-metric/should-render-with-positive-negative-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+65 Bytes
(100%)
...as-metric/should-render-with-positive-negative-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+71 Bytes
(100%)
...c-vertical/bullet-as-metric/should-render-with-positive-values-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+67 Bytes
(100%)
...l/bullet-as-metric/should-render-with-positive-values-reversed-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.35 KB
(98%)
...izing/should-accommodate-chart-title-and-description-metric-sm-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+502 Bytes
(100%)
...a-badge-props/extra-badge-with-big-breakpoints-with-trend-both-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+500 Bytes
(100%)
...a-badge-props/extra-badge-with-big-breakpoints-with-trend-icon-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+513 Bytes
(100%)
...-badge-props/extra-badge-with-big-breakpoints-with-trend-value-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-462 Bytes
(97%)
...badge-props/extra-badge-with-small-breakpoints-with-trend-both-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-460 Bytes
(97%)
...badge-props/extra-badge-with-small-breakpoints-with-trend-icon-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-462 Bytes
(97%)
...adge-props/extra-badge-with-small-breakpoints-with-trend-value-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-459 Bytes
(96%)
...ar-type/dark-theme/should-render-metric-with-click-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-448 Bytes
(96%)
...ar-type/dark-theme/should-render-metric-with-hover-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-566 Bytes
(95%)
...type/dark-theme/should-render-metric-with-transparent-bg-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-484 Bytes
(96%)
...r-type/light-theme/should-render-metric-with-click-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-485 Bytes
(96%)
...r-type/light-theme/should-render-metric-with-hover-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-452 Bytes
(96%)
...ype/light-theme/should-render-metric-with-transparent-bg-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-565 Bytes
(95%)
...ic/metric-bar-type/should-render-with-blended-background-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-776 Bytes
(94%)
...ne-type/dark-theme/should-render-metric-with-click-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-761 Bytes
(94%)
...ne-type/dark-theme/should-render-metric-with-hover-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-760 Bytes
(94%)
...type/dark-theme/should-render-metric-with-transparent-bg-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-843 Bytes
(94%)
...e-type/light-theme/should-render-metric-with-click-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-853 Bytes
(93%)
...e-type/light-theme/should-render-metric-with-hover-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-796 Bytes
(94%)
...ype/light-theme/should-render-metric-with-transparent-bg-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-818 Bytes
(94%)
...c/metric-none-type/should-render-with-blended-background-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-769 Bytes
(95%)
...nd-type/dark-theme/should-render-metric-with-click-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-756 Bytes
(95%)
...nd-type/dark-theme/should-render-metric-with-hover-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-737 Bytes
(95%)
...type/dark-theme/should-render-metric-with-transparent-bg-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-828 Bytes
(94%)
...d-type/light-theme/should-render-metric-with-click-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-832 Bytes
(94%)
...d-type/light-theme/should-render-metric-with-hover-interaction-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-791 Bytes
(94%)
...ype/light-theme/should-render-metric-with-transparent-bg-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-808 Bytes
(94%)
.../metric-trend-type/should-render-with-blended-background-color-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.34 KB
(98%)
...test.ts-snapshots/metric/should-render-horizontal-progress-bar-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.4 KB
(98%)
...hots/metric/should-render-horizontal-progress-bar-in-dark-mode-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-579 Bytes
(98%)
...t.ts-snapshots/metric/should-render-metric-value-fit-font-size-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.34 KB
(98%)
...stories.test.ts-snapshots/metric/should-render-no-progress-bar-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.4 KB
(98%)
...ts-snapshots/metric/should-render-no-progress-bar-in-dark-mode-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.5 KB
(97%)
...pshots/metric/should-render-vertical-progress-bar-in-dark-mode-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.53 KB
(97%)
.../metric/should-render-with-empty-and-missing-background-colors-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1021 Bytes
(110%)
...ies.test.ts-snapshots/metric/small-size-with-default-font-size-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
+1 KB
(110%)
...stories.test.ts-snapshots/metric/small-size-with-fit-font-size-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-45 Bytes
(99%)
...ories.test.ts-snapshots/metric/small-size-with-fixed-font-size-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-151 Bytes
(99%)
.../metric_stories.test.ts-snapshots/metric/text-value-with-trend-chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-120 Bytes
(99%)
...ic_stories.test.ts-snapshots/metric/value-icon-and-value-color-chrome-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.