style: Remove EUI Sass component-specific variable #2528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
changed the title
1 task
Contributor
Author
|
buildkite test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
👋 Hey y'all! I'm cleaning up some Sass exports (specifically of component-specific variables) in EUI's public exports and noticed this one variable usage that has no other usages in Kibana or Cloud. I'm switching it to a more generic equivalent that should not cause any UI regressions within the Amsterdam theme.
For the full list of mixins/variables being removed, see elastic/eui#8031
Checklist
lightanddarkthemes