fix(axis): always render tickLine unless visible is false

[nickofthyme]

Summary

Now axes tickLine are always rendered unless visible is false, thereby including the tickLine.padding even if the tickLine.size or tickLine.strokeWidth are 0.

BREAKING CHANGE: Now displays padding where before would be hidden possibly creating an inadvertent breaking style change.

Notice the bottom axes, as the tickLine.size goes to 0 the padding does not get removed.

Details

This logic was added back in #711 with a complete overhall of the axes logic. This was added to render only things that absolutely needed to be rendered and a 0 length or strokeWidth line does not. However this would unexpectedly strip away the tickLine.padding even with the tickLine.visible set to true. This change should have minimal impact across kibana but better to perform this change now with the major theme breaking changes.

elastic-charts/packages/charts/src/chart_types/xy_chart/utils/axis_utils.ts

Lines 294 to 296 in 132327d

	export function shouldShowTicks({ visible, strokeWidth, size }: AxisStyle['tickLine'], axisHidden: boolean): boolean {
	return !axisHidden && visible && size > 0 && strokeWidth >= MIN_STROKE_WIDTH;
	}

Issues

Fix #2187

Checklist

• The proper chart type label has been added (e.g. :xy, :partition)
• The proper feature labels have been added (e.g. :interactions, :axis)
• All related issues have been linked (i.e. closes #123, fixes #123)
• Unit tests have been added or updated to match the most common scenarios