fix(metric): use a correct React key for each grid item #1789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
bug
drewdaemon
approved these changes
Aug 18, 2022
Collaborator
drewdaemon
left a comment
drewdaemon
left a comment
There was a problem hiding this comment.
Looks great and makes sense.
nickofthyme
pushed a commit
that referenced
this pull request
Aug 23, 2022
## [47.2.1](v47.2.0...v47.2.1) (2022-08-23) ### Bug Fixes * **deps:** update dependency @elastic/eui to v63 ([#1783](#1783)) ([554f370](554f370)) * **deps:** update dependency @elastic/eui to v64 ([#1798](#1798)) ([bb028e9](bb028e9)) * **metric:** clip title at right length ([#1790](#1790)) ([7d7ad55](7d7ad55)) * **metric:** use a correct React key for each grid item ([#1789](#1789)) ([076406e](076406e))
monfera
pushed a commit
to monfera/elastic-charts
that referenced
this pull request
Aug 23, 2022
This PR fixes the problem caused by a wrongly generated React key on each grid items.
monfera
pushed a commit
to monfera/elastic-charts
that referenced
this pull request
Aug 23, 2022
## [47.2.1](elastic/elastic-charts@v47.2.0...v47.2.1) (2022-08-23) ### Bug Fixes * **deps:** update dependency @elastic/eui to v63 ([elastic#1783](elastic#1783)) ([554f370](elastic@554f370)) * **deps:** update dependency @elastic/eui to v64 ([elastic#1798](elastic#1798)) ([bb028e9](elastic@bb028e9)) * **metric:** clip title at right length ([elastic#1790](elastic#1790)) ([7d7ad55](elastic@7d7ad55)) * **metric:** use a correct React key for each grid item ([elastic#1789](elastic#1789)) ([076406e](elastic@076406e))
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the problem caused by a wrongly generated React key on each grid items.
The story is updated with a button to randomized the dataset and a switch to enable a visual debug (showing the values of the passed data).
Warning flashing images below:
Issues
fix #1778
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)