Skip to content

fix(style): remove unnecessary eui exports#1636

Merged
nickofthyme merged 1 commit intoelastic:masterfrom
markov00:2022_03_30-fix_eui_exported_sass
Mar 30, 2022
Merged

fix(style): remove unnecessary eui exports#1636
nickofthyme merged 1 commit intoelastic:masterfrom
markov00:2022_03_30-fix_eui_exported_sass

Conversation

@markov00
Copy link
Collaborator

Summary

This fix reverts a suggestion that imported unwanted classes into our exported CSS files.
We are now importing only mixins and variables that will not pollute the generated CSS with unwanted classes like the date picker and some utility classes

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)

@markov00 markov00 added :styling Styling related issue :all Applies to all chart types labels Mar 30, 2022
@nickofthyme nickofthyme merged commit 3b8243c into elastic:master Mar 30, 2022
@nickofthyme nickofthyme changed the title fix(style): don't export EUI styles fix(style): remove unnecessary eui exports Mar 30, 2022
@markov00 markov00 deleted the 2022_03_30-fix_eui_exported_sass branch April 11, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:all Applies to all chart types :styling Styling related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants