Skip to content

fix(xy): adding missing last tick and other tick improvements#1448

Merged
monfera merged 8 commits intoelastic:masterfrom
monfera:time-tick-grid-iteration
Nov 1, 2021
Merged

fix(xy): adding missing last tick and other tick improvements#1448
monfera merged 8 commits intoelastic:masterfrom
monfera:time-tick-grid-iteration

Conversation

@monfera
Copy link
Contributor

@monfera monfera commented Oct 29, 2021

Summary

Changes:

  • re-add the last tick line on the right, even if there's no room for the belonging label
  • avoid a tick line if it doesn't add info (copying this feature from the prototype) to avoid too many "whiskers" sprouting from the axis line
  • limit the number of gridlines to 12 (while the number of ticks is still limited to 50, so there are often more ticks than grids)
  • experiment possibility: set HIDE_MINOR_TIME_GRID to true (not used now)

image

Details

Issues

Partial fulfilment of #1442

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The :theme label has been added and the @elastic/eui-design team has been pinged when there are Theme API changes
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@monfera monfera added :axis Axis related issue :xy Bar/Line/Area chart related bug Something isn't working labels Oct 29, 2021
@monfera monfera marked this pull request as draft October 29, 2021 07:59
@monfera monfera added the wip work in progress label Oct 29, 2021
@monfera monfera force-pushed the time-tick-grid-iteration branch from c9810c7 to e79cd5b Compare October 29, 2021 08:23
@monfera monfera requested a review from markov00 October 29, 2021 15:17
@monfera monfera marked this pull request as ready for review October 29, 2021 15:18
…ation

# Conflicts:
#	integration/tests/__image_snapshots__/axis-stories-test-ts-axis-stories-theme-eui-dark-should-switch-to-a-30-minute-raster-1-snap.png
#	integration/tests/__image_snapshots__/axis-stories-test-ts-axis-stories-theme-eui-light-should-switch-to-a-30-minute-raster-1-snap.png
@monfera monfera removed the wip work in progress label Oct 29, 2021
Copy link
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a small artifact when hiding ticks (as shown in the above picture), the improvement looks great, tick ratification reduces the gridline noise and without sacrificing too much the readability of the chart.

Screenshot 2021-11-01 at 09 42 09

@monfera monfera enabled auto-merge (squash) November 1, 2021 09:26
@monfera monfera merged commit 002e4b8 into elastic:master Nov 1, 2021
nickofthyme pushed a commit that referenced this pull request Nov 1, 2021
## [38.1.3](v38.1.2...v38.1.3) (2021-11-01)

### Bug Fixes

* **deps:** update dependency @elastic/eui to ^40.1.0 ([#1449](#1449)) ([33a24fb](33a24fb))
* **xy:** adding missing last tick and rarify gridlines ([#1448](#1448)) ([002e4b8](002e4b8))
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 38.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:axis Axis related issue bug Something isn't working released Issue released publicly :xy Bar/Line/Area chart related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants