feat(settings): expose global charts context for settings#1424
Draft
nickofthyme wants to merge 3 commits intoelastic:mainfrom
Draft
feat(settings): expose global charts context for settings#1424nickofthyme wants to merge 3 commits intoelastic:mainfrom
nickofthyme wants to merge 3 commits intoelastic:mainfrom
Conversation
Collaborator
Author
|
We have discussed moving the eui theme into charts and providing a single theme. This could be useful to easily access the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adds
ElasticChartsProviderto passEchContextvalue to set globally shared values across all chart instances. This remediates the need to provide athemeandbaseThemeto all chart instances, thethemewill just be merged with any provided usertheme, when the chart is wrapped in the provider.used as...
Details
Leaving the api for
EchContextopen for future props beyond justsettings.Issues
This completes a long ignored usage for shared global settings
fix #718
Depends on #1421
Checklist
:xy,:partition):interactions,:axis):themelabel has been added and the@elastic/eui-designteam has been pinged when there areThemeAPI changescloses #123,fixes #123)packages/charts/src/index.tsdark,light,eui-dark&eui-light