Conversation
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, I would suggest a slightest simplified API. See comments.
monfera
left a comment
There was a problem hiding this comment.
LGTM, good to merge once it passes and conflicts are resolved
Switching to some color object (or fake enum) would be sensible if we expect significant growth to the count of these constants, or a COLOR_ prefix at least. With the current handful of colors, I don't feel strongly either way. Worth doing a last minute grep for all string occurrences 'black' or even without quotes to ferret out template string occurrences or similar
|
just an update: I've found that |
7148acf to
604b153
Compare
|
close in favour of #1397 |
Summary
During the heatmap legend fixes I've noticed that we have multiple places where some standard colors are allocated.
I've moved the
Colortype + some static colors (red, white, black, transparent) into thecommon/color.tsfile.This is not a complete refactoring but the first part of the initiative to cleanup the folders the typings.
Checklist
:xy,:partition):interactions,:axis)