Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heatmap): pick correct brush end value #1230

Merged
merged 2 commits into from
Jul 6, 2021
Merged

fix(heatmap): pick correct brush end value #1230

merged 2 commits into from
Jul 6, 2021

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Jul 5, 2021

Summary

The heatmap brush selection, on temporal heatmaps, has been fixed correctly computing the visible area and limiting the area to the only hovered cells.

Details

A recent merged change #1212 caused this issue. The brush area was computed without considering the right end value for time series.
The PR adds also two more unit test to cover the case

Issues

fix #1229

Checklist

  • The proper chart type label was added (e.g. :xy, :partition) if the PR involves a specific chart type
  • The proper feature label was added (e.g. :interactions, :axis) if the PR involves a specific chart feature
  • Whenever possible, please check if the closing issue is connected to a running GH project
  • Unit tests were updated or added to match the most common scenarios

@markov00 markov00 added bug Something isn't working :interactions Interactions related issue regression :heatmap Heatmap/Swimlane chart related issue labels Jul 5, 2021
darnautov
darnautov approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markov00 markov00 merged commit 57678fe into elastic:master Jul 6, 2021
@markov00 markov00 deleted the 2021_07_05-fix_heatmap_brush_x branch July 6, 2021 12:34
nickofthyme pushed a commit that referenced this pull request Jul 6, 2021
@semantic-release-bot
chore(release): 31.1.0 [skip ci]
f8a7111 
# [31.1.0](v31.0.0...v31.1.0) (2021-07-06)

### Bug Fixes

* **heatmap:** pick correct brush end value ([#1230](#1230)) ([57678fe](57678fe)), closes [#1229](#1229)

### Features

* **a11y:** accessible goal and gauge chart ([#1174](#1174)) ([ffa8822](ffa8822)), closes [#1160](#1160)
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 31.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jul 6, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 31.1.0 [skip ci]
ad6591f 
# [31.1.0](elastic/elastic-charts@v31.0.0...v31.1.0) (2021-07-06)

### Bug Fixes

* **heatmap:** pick correct brush end value ([opensearch-project#1230](elastic/elastic-charts#1230)) ([cb95a75](elastic/elastic-charts@cb95a75)), closes [opensearch-project#1229](elastic/elastic-charts#1229)

### Features

* **a11y:** accessible goal and gauge chart ([#1174](elastic/elastic-charts#1174)) ([775dc98](elastic/elastic-charts@775dc98)), closes [opensearch-project#1160](elastic/elastic-charts#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@nickofthyme nickofthyme Awaiting requested review from nickofthyme

@rshen91 rshen91 Awaiting requested review from rshen91

Assignees
No one assigned
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue :interactions Interactions related issue regression released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brush area is off by 1 cell
3 participants
@markov00 @nickofthyme @darnautov