enhancement(5235): removed nolint:gosec // legacy from step_unpack#9345
Closed
kaanyalti wants to merge 1 commit intoelastic:mainfrom
Closed
enhancement(5235): removed nolint:gosec // legacy from step_unpack#9345kaanyalti wants to merge 1 commit intoelastic:mainfrom
kaanyalti wants to merge 1 commit intoelastic:mainfrom
Conversation
kaanyalti
added
Team:Elastic-Agent-Control-Plane
kaanyalti
changed the title
kaanyalti
added
backport-active-all
the correct line
kaanyalti
force-pushed
the
chore/5235_remove_nolint_gosec_from_step_unpack
branch
from
a31c770 to
a752c93
Compare
Contributor
|
|
Author
|
Renamed the branch and recreated the pr here #9347 |
|
Contributor
💛 Build succeeded, but was flaky
Failed CI Stepscc @kaanyalti |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed gosec:nolint from step_unpack
Why is it important?
gosec:nolint is causing
nolintlinterrorChecklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
none
How to test this PR locally
not necessary
Related issues