Enhancement/5235 upgrade cleanup after error#9250

Closed

kaanyalti wants to merge 127 commits intoelastic:mainfrom

kaanyalti:enhancement/5235_upgrade_cleanup_after_error

Commits on Jul 31, 2025

enhancement(5235): added disc space error function to respond to the user with a clean disk space error, updated all necessary components to inject the error parsing function
kaanyalti
committed
enhancement(5235): updated error wrapping
kaanyalti
committed
enhancement(5235): revert test timeout
kaanyalti
committed
enhancement(5235): added progress reporter test
kaanyalti
committed
enhancement(5235): added test for ReportFailed
kaanyalti
committed
enhancement(5235): created disk space error type, wrapping backoff permanent error type
kaanyalti
committed
enhancement(5235): reverted downloader with retry changes
kaanyalti
committed
enhancement(5235): added insufficient disk space error type, moved error conversion into the downloader for http downloader
kaanyalti
committed
enhancement(5235): updated insufficient disk error, removed backoff related wrapping. updated download with retries to wrap the error in permanent error if the error is insufficient disk error.
kaanyalti
committed
enhancement(5235): moved disk space error into its own package under upgrades. reverted constructor signature changes. updated tests
kaanyalti
committed
enhancement(5235): removed unnecessary error files
kaanyalti
committed
enhancement(5235): added progress reporter interface in http downloader, updated tests
kaanyalti
committed
enhancement(5235): updated tests
kaanyalti
committed
enhancement(5235): updated tests
kaanyalti
committed
enhancement(5235): added downloader factory provider and updated tests
kaanyalti
committed
enhancement(5235): updated progress reporter prepare function, fixed cleanup for file downloader, added end-to-end tests for the upgrade manager upgrade function
kaanyalti
committed
enhancement(5235): refactored end to end upgrade tests to assert copy errors for file downloader and composed downloader
kaanyalti
committed
enhancement(5235): updated fs downloader download tests
kaanyalti
committed
enhancement(5235): added tests for progress reporter prepare
kaanyalti
committed
enhancement(5235): removed unnecessary logging
kaanyalti
committed
enhancement(5235): injecting details provider. added tests for setting details provider, and end to end test to assert error messages correctly bubble up
kaanyalti
committed
enhancement(5235): ran mage check
kaanyalti
committed
enhancement(5235): added changelog
kaanyalti
committed
enhancment(5235): removed commented code
kaanyalti
committed
enhancement(5235): fix linting errors
kaanyalti
committed
enhancement(5235): fix test cases
kaanyalti
committed
enhancement(5235): updated tests, removed unused var
kaanyalti
committed
enhancement(5235): updated progress reporter to avoid data race
kaanyalti
committed
enhancement(5235): removed reference to embedded type
kaanyalti
committed
enhancement(5235): returning path from download functions
kaanyalti
committed
enhancement(5235): using config arch instead of runtime arch
kaanyalti
committed
enhancement(5235): updated download functions to remove the base directory to cleanup instead of individual files
kaanyalti
committed
enhancement(5235): refactored artifact test
kaanyalti
committed
enhancement(5235): ran mage check
kaanyalti
committed
enhancement(5235): removed unnecessary comments
kaanyalti
committed

Commits on Aug 4, 2025

Commits on Aug 5, 2025

enhancement(5235): updated error handling in upgrade function
kaanyalti
committed
enhancement(5235): added artifact downloader interface, updated tests
kaanyalti
committed
enhancement(5235): added unpacker interface, updated tests
kaanyalti
committed
enhancement(5235): added replacer interface
kaanyalti
committed

Commits on Aug 6, 2025

enhancement(5235): added watcher interface and updated tests
kaanyalti
committed
enhancement(5235): removed test case
kaanyalti
committed
enhancement(5235): moved clean up function into step download, removed cleanup files
kaanyalti
committed
enhancement(5235): added relinker interface
kaanyalti
committed
enhancement(5235): added directory copier interface
kaanyalti
committed
enhancement(5235): moved unpacker functions into one file
kaanyalti
committed
enhancement(5235): moved ugprade wather and marker functions into one file
kaanyalti
committed
enhancement(5235): refactpred upgrade watcher functions and tests
kaanyalti
committed
enhancement(5235): removed replacer interface
kaanyalti
committed
enhancement(5235): moved directory copy functions, moved relevant tests
kaanyalti
committed
enhancement(5235): added invokeWatcher to upgradeWatcher to implement the watcher interface
kaanyalti
committed
enhancement(5235): added upgrade executor
kaanyalti
committed
enhancement(5235): removed commented code
kaanyalti
committed
enhancement(5235): updated download error tests
kaanyalti
committed

Commits on Aug 7, 2025

enhancement(5235): refactored interfaces and commented unused code
kaanyalti
committed
enhancement(5235): added download artifact step test case
kaanyalti
committed
enhancement(5235): remove commented code
kaanyalti
committed
enhancement(5235): added tests for executor download step, will need to refactor the test cases
kaanyalti
committed
enhancement(5235): updated mockery config and added mocks for the interfaces that the executor uses
kaanyalti
committed
enhancemen(5235): added wathcer mock
kaanyalti
committed
enhancement(5235): added download step tests
kaanyalti
committed
enhancement(5235): removed newHash from unpack step result
kaanyalti
committed
enhancement(5235): injecting check upgrade fn into unpack step
kaanyalti
committed
enhancement(5235): removed testValues from download step test
kaanyalti
committed
enhancement(5235): added unpack step tests
kaanyalti
committed
enhancement(5235): removed import type alias
kaanyalti
committed
enhancement(5235): added check upgrade fn
kaanyalti
committed
enhancement(5235): remove commented struct fields
kaanyalti
committed
enhancement(5235): removed commented code
kaanyalti
committed
enhancement(5235): injecting check upgrade fn in upgrade function
kaanyalti
committed

Commits on Aug 8, 2025

enhancement(5235): removed logger from replace old with new function signature
kaanyalti
committed
enhancement(5235): removed logger from replace old with new func definition
kaanyalti
committed
enhancement(5235): added replace old with new unit tests
kaanyalti
committed
enhancement(5235): remove unnecessary func encapsulation
kaanyalti
committed
enhancement(5235): removed unnecessary func encapsulation
kaanyalti
committed
enhancement(5235): added import
kaanyalti
committed
enhancement(5235): removed logger from watchNewAgent function signature
kaanyalti
committed
enhancmenet(5235): removed log from watch new agent function call
kaanyalti
committed
enhancement(5235): added tests for watch new agent
kaanyalti
committed
enhancement(5235): removed upgrade abstraction, using the new upgrade function
kaanyalti
committed
enhancement(5235): added upgrade executor mock, added tests
kaanyalti
committed
enhancement(5235): removed nil error check from deferred cleanup
kaanyalti
committed
enhancement(5235): removed commented test code from fs downloader tests
kaanyalti
committed
enhancement(5235): using download results instead of archive path in fs downloader test
kaanyalti
committed
enhancement(5235): using download result instead of archive path in http downloader test
kaanyalti
committed
enhancement(5235): removed dev logs
kaanyalti
committed
enhancement(5235): asserting downloads dir is cleaned up if upgrade is successful
kaanyalti
committed
enhancement(5235): added package scoped var for unpack step to abstract io.Copy
kaanyalti
committed
enhancement(5235): returning unpack result with hash
kaanyalti
committed
enhancement(5235): added tests for copy func errors in unpack
kaanyalti
committed

Commits on Aug 9, 2025

enhancement(5235): added asc downloader and tests back in
kaanyalti
committed
enhancement(5235): asserting returned error
kaanyalti
committed
enhancement(5235): moved test functions around
kaanyalti
committed
enhancement(5235): added unpack step error handling tests
kaanyalti
committed
enhancement(5235): removed unnecessary commented code
kaanyalti
committed
enhancement(5235): removed dev comment
kaanyalti
committed
enhancement(5235): using config to get os and arch instead of runtime
kaanyalti
committed
enhancmenet(5235): using config to get os and arch
kaanyalti
committed
enhancement(5235): updated comment
kaanyalti
committed

Commits on Aug 10, 2025

enhancement(5235): added package level exported var for paths.Home() for testability
kaanyalti
committed
enhancement(5235): added package level vars for cop.Copy and os.WriteFile for testing
kaanyalti
committed
enhancement(5235): added function to check archive files are extracted correctly using manifest and versioned home
kaanyalti
committed
enhancement(5235): added helper functions to create archives and added action store error handling test
kaanyalti
committed
enhancement(5235): updated the use of archive helpers in unpack error handling tests
kaanyalti
committed
enhancement(5235): updated test function names
kaanyalti
committed
enhancement(5235): use home path to get run path
kaanyalti
committed
enhancement(5235): added run dir copy error test
kaanyalti
committed
enhancement(5235): refactored action store copy and run dir copy error tests
kaanyalti
committed
enhancement(5235): updated archive file modification functions
kaanyalti
committed
enhancement(5235): using config target path for assertion
kaanyalti
committed
enhancement(5235): added package symlink func to abstract os symlink
kaanyalti
committed
enhancement(5235): removed unused var from function, regenerated mocks
kaanyalti
committed
enhancement(5235): using homepath instead of home
kaanyalti
committed
enhancement(5235): update mock use in test
kaanyalti
committed
enhancement(5235): added symlink error test
kaanyalti
committed
enhancement(5235): added mark upgrade error handling test
kaanyalti
committed
enhancement(5235): added diskspace error conversion
kaanyalti
committed
enhancement(5235): using writefile stub
kaanyalti
committed
enhancement(5235): added command exec package var in rollback
kaanyalti
committed
enhancement(5235): added release ugpradeable and context timeout package vars for testing
kaanyalti
committed
enhancement(5235): added invoke wathcer and wait for watcher error handling test cases
kaanyalti
committed