Add custom ECH deployment + smoke test#8337
Conversation
Use the image produced in the packaging step as the integrations server image on ECH when a cloud deployment is provisioned for integrations tests. This allows for the changes made in a PR to be tested on the cloud deployment in addition to the current client-focused tests.
|
This PR copies the approach taken by #8035, but applies it to the normal integration test pipeline |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
left a comment
There was a problem hiding this comment.
Looks good enough to me, though I think some of the env variable manipulation in cloud:load is unnecessary.
|
This pull request is now in conflicts. Could you fix it? 🙏 |
v1v
left a comment
There was a problem hiding this comment.
Thanks for cleaning up some of the cosmetic leftovers. I left a few comments
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
pkoutsovasilis
left a comment
There was a problem hiding this comment.
LGTM, @v1v please have another look at your comments, we need this PR as it increases the testing footprint of elastic-agent
v1v
left a comment
There was a problem hiding this comment.
Besides what we discussed in the thread, I approve the CI part
…sts (#8337) Use the image produced in the packaging step as the integrations server image on ECH when a cloud deployment is provisioned for integrations tests. This allows for the changes made in a PR to be tested on the cloud deployment in addition to the current client-focused tests. (cherry picked from commit c1136e4) # Conflicts: # magefile.go
* Use a custom image for the ECH deployment when running integration tests (#8337) Use the image produced in the packaging step as the integrations server image on ECH when a cloud deployment is provisioned for integrations tests. This allows for the changes made in a PR to be tested on the cloud deployment in addition to the current client-focused tests. (cherry picked from commit c1136e4) # Conflicts: # magefile.go * Fix merge conflict --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>





What does this PR do?
Use the image produced in the packaging step as the integrations server image for an ECH deployment and run a basic smoke test against that deployment. This allows for the changes made in a PR to be tested as a part of the cloud image in addition to the current test coverage.
Why is it important?
Removes the 1 day delay from producing a SNAPSHOT image to testing the image.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragmentsusing the changelog toolDisruptive User Impact
N/A