Skip to content

[9.0](backport #6801) [e2e] Add tests for self monitoring agent logs in otel mode#7950

Merged
khushijain21 merged 6 commits into9.0from
mergify/bp/9.0/pr-6801
Apr 28, 2025
Merged

[9.0](backport #6801) [e2e] Add tests for self monitoring agent logs in otel mode#7950
khushijain21 merged 6 commits into9.0from
mergify/bp/9.0/pr-6801

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 24, 2025

What does this PR do?

It adds tests for comparing docs ingested by agent.monitoring vs otel.yml

Notes:
Some changes made to otel.yml produced by hand here:

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

Related issues


This is an automatic backport of pull request #6801 done by [Mergify](https://mergify.com).

- Add tests for self monitoring agent logs in otel mode

(cherry picked from commit 931134f)

# Conflicts:
#	testing/integration/beat_receivers_test.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Apr 24, 2025
@mergify mergify bot requested a review from a team as a code owner April 24, 2025 04:55
@mergify mergify bot removed the request for review from a team April 24, 2025 04:55
@mergify
Copy link
Contributor Author

mergify bot commented Apr 24, 2025

Cherry-pick of 931134f has failed:

On branch mergify/bp/9.0/pr-6801
Your branch is up to date with 'origin/9.0'.

You are currently cherry-picking commit 931134f3f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   testing/integration/otel_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   testing/integration/beat_receivers_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from pchila and swiatekm April 24, 2025 04:55
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Apr 24, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@swiatekm
Copy link
Contributor

swiatekm commented Apr 25, 2025

The only real test failure gives the message Failed to start the collector: invalid configuration: exporters::elasticsearch/log::batcher: flush_timeoutmust be greater than zero\nexporters::elasticsearch/log::batcher::config:flush_timeout must be greater than zero".

Looks like this was originally fixed in #7686, but the backport to 9.0 didn't cover it, because the test didn't exist yet.

@mergify
Copy link
Contributor Author

mergify bot commented Apr 28, 2025

This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏

@elastic-sonarqube
Copy link

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

cc @khushijain21

@khushijain21 khushijain21 merged commit f4ff90c into 9.0 Apr 28, 2025
12 checks passed
@khushijain21 khushijain21 deleted the mergify/bp/9.0/pr-6801 branch April 28, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments