[8.x](backport #7602) Make components in packages configurable#7688
Closed
mergify[bot] wants to merge 1 commit into8.xfrom
Closed
[8.x](backport #7602) Make components in packages configurable#7688mergify[bot] wants to merge 1 commit into8.xfrom
mergify[bot] wants to merge 1 commit into8.xfrom
Conversation
* Redefine ExpectedBinaries as YAML config * Move ExpectedBinaries closer to package spec file * Fix error formatting in downloadDRAArtifacts * add packageName template to ExpectedPackages * use a relaxed dependencies version for IAR releases * Remove FIPS hack introduced in PR #7486 * Allow for a looser match on relaxing dependencies versions * Add debug logging when packaging with EXTERNAL=true * move package tests to dedicated package (cherry picked from commit 894ef93) # Conflicts: # dev-tools/mage/checksums.go # dev-tools/mage/manifest/manifest.go
Contributor
Author
|
Cherry-pick of 894ef93 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows declarative definitions of elastic-agent components in
dev-tools/packaging/packages.yml.In the declaration of such components it's now possible to specify a
packageNametemplate that will be rendered using platform and version during packaging.Why is it important?
This is a prerequisite for selecting different component packages for specific packaging specs.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
No disruptive user impact as neither the mage build targets nor the final packages changed
How to test this PR locally
Package using a manifest
Package without using a manifest
EXTERNAL=true PLATFORMS="linux/amd64" mage clean packageRelated issues
Questions to ask yourself
This is an automatic backport of pull request #7602 done by [Mergify](https://mergify.com).