-
Notifications
You must be signed in to change notification settings - Fork 211
[8.18](backport #7172) Use elastic apm connector to replace other apm components #7452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cherry-pick of efeb73b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
(cherry picked from commit efeb73b) # Conflicts: # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/README.md
1f3a1fe to
0fcf60d
Compare
lahsivjar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
💚 Build Succeeded
History
|




What does this PR do?
The PR replaces
lsmintervalprocessor andsignaltometricsconnector with the newly introducedelasticapmconnector which wraps both the processor and the connector with the required APM configurations.In addition, the PR also removes aggregation for metrics pipeline as required by elastic/opentelemetry-collector-components#390
The PR is same as #6937 but for 9.0 branch since the upgrade of otel components to version 0.120.0 has been merged to 9.0 already however, the main PR is still pending.
Why is it important?
To centralize all APM components and configurations a new connector component called elasticapmconnector was recently introduced. The component encapsulates the signaltometrics connector and the lsminterval connector along with the required configurations for APM.
To handle metrics-only services correctly for the UI.
Checklist
- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry in./changelog/fragmentsusing the changelog tool- [ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself
This is an automatic backport of pull request #7172 done by [Mergify](https://mergify.com).