-
Notifications
You must be signed in to change notification settings - Fork 210
[8.18](backport #7023) Remove filebeatreceiver and metricbeat receiver to remove dependency on Beats #7051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cherry-pick of 7f18476 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
9a18623 to
ed78b13
Compare
fe90900 to
c6bfadd
Compare
|
We are going to vendor the Prometheus dependency in Beats to hopefully prevent us from needing to do this in this branch elastic/beats#42890 |
c6bfadd to
39a7ba4
Compare
|
This pull request has not been merged yet. Could you please review and merge it @swiatekm? 🙏 |
39a7ba4 to
07b47d2
Compare
|
This pull request has not been merged yet. Could you please review and merge it @swiatekm? 🙏 |
07b47d2 to
0cafafa
Compare
@cmacknz PR elastic/beats#42890 has been closed. Should this be merged then or we are evaluating alternatives? |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
This pull request has not been merged yet. Could you please review and merge it @swiatekm? 🙏 |
0cafafa to
a2d39e0
Compare
(cherry picked from commit 7f18476) # Conflicts: # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/components.go # testing/integration/otel_test.go # Conflicts: # NOTICE.txt # go.mod # go.sum
a2d39e0 to
b5858eb
Compare
|
💚 Build Succeeded
History
cc @swiatekm |
|
Closing in favor of #7443. |





What does this PR do?
Removes the filebeatreceiver and metricbeatreceiver and associated tests from the 9.0 branch.
Why is it important?
We need to update our dependency on otel-collector-contrib to get fixes to the elasticsearchexporter that the EDOT collector needs to go GA in 9.0. This update cannot be done because the otel dependency versions in Beats conflicts with the one we need. We can't update the otel dependency versions in Beats without upgraded Beats' dependency on the Prometheus packages, which introduce breaking changes we need time to adapt to. For full details see elastic/beats#42748.
There is no fast fix to this on the Beats side, this is IMO the least bad option. The other quick alternative would be to have Elastic Agent's 9.0 branch point to a feature branch in Beats with the dependency update (so 9.0 here would not point to 9.0 in Beats). That is less disruptive in this repository, but creates another unofficial branch to maintain as long as this situation goes on, and does not prevent this problem happening again with another dependency later that would require more work in the unofficial Beats branch. If it turns out this was the wrong decision, we can switch to the other approach at any time in the future by reverting this commit.
The intent is we'll revert this and bring the beat receiver components back once Beats can safely be updated to the appropriate OTel dependencies.
Disruptive User Impact
None, beats receivers are experimental and unannounced. This change isolates any impact to functionality that isn't meant to be usable externally in 9.0.
Related / blocked issues
This is an automatic backport of pull request [9.0] Remove filebeatreceiver and metricbeat receiver to remove dependency on Beats #7023 done by Mergify.