Fix runtime error reporting in Otel manager #6793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
added
bug
cmacknz
approved these changes
Feb 10, 2025
blakerouse
approved these changes
Feb 10, 2025
Contributor
blakerouse
left a comment
blakerouse
left a comment
There was a problem hiding this comment.
Ahhh, my bad! Looks good.
swiatekm
force-pushed
the
fix/otel-manager-errors
branch
from
544374c to
23f8aba
Compare
|
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 371399c)
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 371399c)
This was referenced Feb 11, 2025
swiatekm
added a commit
that referenced
this pull request
Feb 11, 2025
(cherry picked from commit 371399c)
swiatekm
added a commit
that referenced
this pull request
Feb 12, 2025
(cherry picked from commit 371399c)
swiatekm
added a commit
that referenced
this pull request
Feb 12, 2025
swiatekm
added a commit
that referenced
this pull request
Feb 13, 2025
(cherry picked from commit 371399c)
swiatekm
added a commit
that referenced
this pull request
Feb 13, 2025
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
(cherry picked from commit 371399c) # Conflicts: # internal/pkg/otel/manager/manager.go # internal/pkg/otel/manager/manager_test.go
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug where the Otel manager wouldn't report runtime errors to the coordinator.
Why is it important?
The coordinator needs to know about errors encountered by the otel manager.
Checklist
Related issues