feat: drop init.d support and go-daemon binaries#6174
feat: drop init.d support and go-daemon binaries#6174kruskall wants to merge 7 commits intoelastic:mainfrom
Conversation
remove init.d scripts drop go-daemon dep and daemon binaries cleanup mage tasks
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
|
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
kaanyalti
left a comment
There was a problem hiding this comment.
Code changes look good to me, but I don't have enough context here, if someone else can look at it as well it would be better.
|
This is fine as long as the DEB and RPM packages still run as services. That there is no replacement systemd unit file added here makes me think we may have broken something. I see the DEB tests are failing now, so that is one potential reason. We create out existing systemd service in Go code right now so there isn't an easy way to extract it without refactoring that. |
blakerouse
left a comment
There was a problem hiding this comment.
I think this change is possible because it is true that on DEB/RPM that we do not support any OS that uses sysvinit. But there is clearly an issue with the upgrade path for the deb packages.
Interested to determine what you find on why that is not working with these changes. I am going to mark this as "Request changes" only, because I was to review it again before its merged with that fixed.
|
There is an actual bug related to us continuing to include init.d files now #6704 |
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
💔 Build Failed
Failed CI StepsHistory
cc @kruskall |





What does this PR do?
remove init.d scripts
drop go-daemon dep and daemon binaries
cleanup mage tasks
Why is it important?
Similar to elastic/beats#41845
init.d should not be needed on distros we support
According to go-daemon readme: "Go daemon is not needed on systems with systemd."
See https://www.elastic.co/support/matrix#matrix_os
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself